From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0CEC433E6 for ; Mon, 11 Jan 2021 15:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F44422A83 for ; Mon, 11 Jan 2021 15:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731971AbhAKPNh (ORCPT ); Mon, 11 Jan 2021 10:13:37 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:29803 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731299AbhAKPNg (ORCPT ); Mon, 11 Jan 2021 10:13:36 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610377993; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hirL+bx7ovoUKx/v5BmgMLJbirQ64ET+KGM2Ze9K26Y=; b=sOYsrzKkHmppohlAQHvGtFLM0NnYVCuKIpMOSSV0p+1slNVzp7jrBYzA8cRAq08FbAWTgI62 ndVJeCrctYNpQVP+QOtKnZ1wLc1PR189i95CHOhj3xXbWQkPor0g3c+k0csnvDrWeUj10zQ3 sCZTPvsAKU4MZB46LcKL/HM5L+w= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-east-1.postgun.com with SMTP id 5ffc6aec46a6c7cde75fde99 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 Jan 2021 15:12:44 GMT Sender: isaacm=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 551B6C43465; Mon, 11 Jan 2021 15:12:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: isaacm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 55053C433C6; Mon, 11 Jan 2021 15:12:42 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Jan 2021 07:12:42 -0800 From: isaacm@codeaurora.org To: Sai Prakash Ranjan Cc: iommu@lists.linux-foundation.org, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pdaly@codeaurora.org, pratikp@codeaurora.org, robin.murphy@arm.com, will@kernel.org Subject: Re: [PATCH 0/5] Optimize iommu_map_sg() performance In-Reply-To: <5a29b6e339c66e9c7cd9a608baa3f9e1@codeaurora.org> References: <1610157031-26301-1-git-send-email-isaacm@codeaurora.org> <20210111062300.28541-1-saiprakash.ranjan@codeaurora.org> <5a29b6e339c66e9c7cd9a608baa3f9e1@codeaurora.org> Message-ID: <6f57460f1b95373c615fdbad97edd9ed@codeaurora.org> X-Sender: isaacm@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-10 23:52, Sai Prakash Ranjan wrote: > On 2021-01-11 11:52, Sai Prakash Ranjan wrote: >> Hi Isaac, >> >> I gave this series a go on chromebook and saw these warnings >> and several device probe failures, logs attached below: >> >> WARN corresponds to this code in arm_lpae_map_by_pgsize() >> >> if (WARN_ON(iaext || (paddr + size) >> cfg->oas)) >> return -ERANGE; >> >> Logs: >> >> [ 2.411391] ------------[ cut here ]------------ >> [ 2.416149] WARNING: CPU: 6 PID: 56 at >> drivers/iommu/io-pgtable-arm.c:492 arm_lpae_map_sg+0x234/0x248 >> [ 2.425606] Modules linked in: >> [ 2.428749] CPU: 6 PID: 56 Comm: kworker/6:1 Not tainted 5.10.5 >> #970 >> [ 2.440287] Workqueue: events deferred_probe_work_func >> [ 2.445563] pstate: 20c00009 (nzCv daif +PAN +UAO -TCO BTYPE=--) >> [ 2.451726] pc : arm_lpae_map_sg+0x234/0x248 >> [ 2.456112] lr : arm_lpae_map_sg+0xe0/0x248 >> [ 2.460410] sp : ffffffc010513750 >> [ 2.463820] x29: ffffffc010513790 x28: ffffffb943332000 >> [ 2.469281] x27: 0000000ffffff000 x26: ffffffb943d14900 >> [ 2.474738] x25: 0000000000001000 x24: 0000000103465000 >> [ 2.480196] x23: 0000000000000001 x22: 0000000103466000 >> [ 2.485645] x21: 0000000000000003 x20: 0000000000000a20 >> [ 2.491103] x19: ffffffc010513850 x18: 0000000000000001 >> [ 2.496562] x17: 0000000000000002 x16: 00000000ffffffff >> [ 2.502021] x15: 0000000000000000 x14: 0000000000000000 >> [ 2.507479] x13: 0000000000000001 x12: 0000000000000000 >> [ 2.512928] x11: 0000001000000000 x10: 0000000000000000 >> [ 2.518385] x9 : 0000000000000001 x8 : 0000000040201000 >> [ 2.523844] x7 : 0000000000000a20 x6 : ffffffb943463000 >> [ 2.529302] x5 : 0000000000000003 x4 : 0000000000001000 >> [ 2.534760] x3 : 0000000000000001 x2 : ffffffb941f605a0 >> [ 2.540219] x1 : 0000000000000003 x0 : 0000000000000e40 >> [ 2.545679] Call trace: >> [ 2.548196] arm_lpae_map_sg+0x234/0x248 >> [ 2.552225] arm_smmu_map_sg+0x80/0xc4 >> [ 2.556078] __iommu_map_sg+0x6c/0x188 >> [ 2.559931] iommu_map_sg_atomic+0x18/0x20 >> [ 2.564144] iommu_dma_alloc_remap+0x26c/0x34c >> [ 2.568703] iommu_dma_alloc+0x9c/0x268 >> [ 2.572647] dma_alloc_attrs+0x88/0xfc >> [ 2.576503] gsi_ring_alloc+0x50/0x144 >> [ 2.580356] gsi_init+0x2c4/0x5c4 >> [ 2.583766] ipa_probe+0x14c/0x2b4 >> [ 2.587263] platform_drv_probe+0x94/0xb4 >> [ 2.591377] really_probe+0x138/0x348 >> [ 2.595145] driver_probe_device+0x80/0xb8 >> [ 2.599358] __device_attach_driver+0x90/0xa8 >> [ 2.603829] bus_for_each_drv+0x84/0xcc >> [ 2.607772] __device_attach+0xc0/0x148 >> [ 2.611713] device_initial_probe+0x18/0x20 >> [ 2.616012] bus_probe_device+0x38/0x94 >> [ 2.619953] deferred_probe_work_func+0x78/0xb0 >> [ 2.624611] process_one_work+0x210/0x3dc >> [ 2.628726] worker_thread+0x284/0x3e0 >> [ 2.632578] kthread+0x148/0x1a8 >> [ 2.635891] ret_from_fork+0x10/0x18 >> [ 2.639562] ---[ end trace 9bac18cad6a9862e ]--- >> [ 2.644414] ipa 1e40000.ipa: error -12 allocating channel 0 event >> ring >> [ 2.651656] ipa: probe of 1e40000.ipa failed with error -12 >> [ 2.660072] dwc3 a600000.dwc3: Adding to iommu group 8 >> [ 2.668632] xhci-hcd xhci-hcd.13.auto: xHCI Host Controller >> [ 2.674680] xhci-hcd xhci-hcd.13.auto: new USB bus registered, >> assigned bus number 1 >> > > ... > > Isaac provided a fix which he will post as v2 and no warnings were > observed > with that fix. > > Tested-by: Sai Prakash Ranjan > > Thanks, > Sai Thanks for testing out the patches. I've added the fix (there was an off-by-one error in the calculation used to check if the IOVA/physical addresses are within limits) to version 2 of the series: https://lore.kernel.org/linux-iommu/1610376862-927-1-git-send-email-isaacm@codeaurora.org/T/#t Thanks, Isaac