From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932199AbcICMcb (ORCPT ); Sat, 3 Sep 2016 08:32:31 -0400 Received: from mout.web.de ([212.227.15.4]:50158 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155AbcICMc3 (ORCPT ); Sat, 3 Sep 2016 08:32:29 -0400 Subject: [PATCH 13/17] s390/debug: Improve a size determination in debug_open() To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <6f816bfa-ea0b-dd1a-24ba-5aeea7519276@users.sourceforge.net> Date: Sat, 3 Sep 2016 14:32:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uiCI7ZXRTcLNvnMENChdYAIjwRplH37smGfkEJ8ZnwLAZp8FHFl BEVHUXwDlgauDPrPWVZYARIfvOAVpI6pz0yoJ+7/d8VD0CJU2keNg8au1QMl3myLtkqB5d7 xvNlWFgNr3rzGuyP4nVjKXeXqRw47aOdicx7GlQMl9knlKDaxq64KpuJhFkUbmROiIUreg/ PfW/KCZOtdPx7Vcu/HPyQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:lxZ/3m45rzI=:b8Rvch2onGnEfluUTTALds uVT3RtIYKoo2rYfoBT+WhQFzSdCkjNRsWFD2ifKoLr/4ziKRwp4ZtE8E2OXHpcwBKwnI/GXvp H8tsXKSYeEhnWAXDwj5kiA7xY9e8Easgh8OcOLZBZ4pAZhaRadkhJZvC4SlFfVZbQLp1SMixy 2yzNWP2Wt1wPpdxVxZ6saItqGL9YPHQWFnSu5y6GYQnjOIXXdvS7cAcVqAFrIXOctfrVRXUOI w587zNARrDkUHDzakAlvzw/nhFY/P2lzCHINwJQ5dFCdkbdYsfxGAf+dGtLiXiBq55wHUO4yc SNEQpRblChYllEmH5UVDw0V0QZ9JGW669s7GIMNKZFkz2Z9KajsANbSBKddUQA8Mtb3qqGimH 0CxKd5G0vmofYZ34KM18Kx/vWgyrMF5OoaK9OCRjDhDVMvPkzK279m1xdAB1aj83XEJT/D06z s5EoWxEaUVMAMMOSzk2Kcj4EN+w2Nc5KOY8vvJYqJQzaepDg7sjW4X6QiSm1v7XO0G5lKdLIx B3pqyIEJoLkbj3NfCjgJMomr5z4rp0vptvMdxZFI9W7P6Np3/+MZg1FA5JFzVXl1Jn6BwX3Te 99Y8BT0W3gRSeHHJBH+FK+vqHQpiHYRmy0E5PvyJ4wrUFLiCX4rYfNq021hF+WwranzfZrBg2 9FboK7a0XzMKPgkbV/tZDp0up2hJTLjdC+lD0T8OXvfhRpTZxp/xi1YBmRr9+2NBLii/d+mt3 zvD28cwEVtkQiEPzmzplx7wG+qGNEfwBuRnwkB+H9Tr/j4mJk9Y3h50FQ5xsI9JQ+WxlpOcu4 d/MToC4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 2 Sep 2016 09:02:22 +0200 * Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Improve source code layout for one function call. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index a9fcf72..32ceb5e 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -636,8 +636,7 @@ debug_open(struct inode *inode, struct file *file) rc = -ENOMEM; goto unlock; } - p_info = kmalloc(sizeof(file_private_info_t), - GFP_KERNEL); + p_info = kmalloc(sizeof(*p_info), GFP_KERNEL); if (!p_info) { debug_info_free(debug_info_snapshot); rc = -ENOMEM; -- 2.9.3