From: stefano.manni@gmail.com
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: nick@shmanahar.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - add wakeup support
Date: Sat, 18 May 2019 18:55:10 +0200 [thread overview]
Message-ID: <6f94097bb9192424f92e055e8af8062b2ae3e19f.camel@gmail.com> (raw)
In-Reply-To: <20190517213016.GA93581@dtor-ws>
Hi Dmitry,
On Fri, 2019-05-17 at 14:30 -0700, Dmitry Torokhov wrote:
> Hi Sefano,
>
> On Fri, May 17, 2019 at 11:17:40PM +0200, Stefano Manni wrote:
> > Add wakeup support to the maxtouch driver.
> > The device can wake up the system from suspend,
> > mark the IRQ as wakeup capable, so that device
> > irq is not disabled during system suspend.
>
> This should already be handled by I2C core, see lines after "if
> (client->flags & I2C_CLIENT_WAKE)" in drivers/i2c/i2c-core-base.c.
>
> Unless there is dedicated wakeup interrupt we configure main
> interrupt
> as wake source.
>
what's about the other drivers (e.g. ili210x.c) doing like this?
Shall they be purged?
Thank you.
next prev parent reply other threads:[~2019-05-18 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 21:17 [PATCH 1/2] Input: atmel_mxt_ts - add wakeup support Stefano Manni
2019-05-17 21:17 ` [PATCH 2/2] dt-bindings: input: Add wakeup-source for atmel,maxtouch Stefano Manni
2019-06-13 22:52 ` Rob Herring
2019-05-17 21:30 ` [PATCH 1/2] Input: atmel_mxt_ts - add wakeup support Dmitry Torokhov
2019-05-18 16:55 ` stefano.manni [this message]
2019-05-21 5:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f94097bb9192424f92e055e8af8062b2ae3e19f.camel@gmail.com \
--to=stefano.manni@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nick@shmanahar.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox