From: Marc Zyngier <maz@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Saravana Kannan <saravanak@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: Fix refcount leak in platform_irqchip_probe
Date: Mon, 02 Jan 2023 12:20:02 +0000 [thread overview]
Message-ID: <6fa4699cc0b1b17943d4c67e53c432a4@kernel.org> (raw)
In-Reply-To: <20230102121318.3990586-1-linmq006@gmail.com>
On 2023-01-02 12:13, Miaoqian Lin wrote:
> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END
> and IRQCHIP_MATCH helper macros")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Please stop sending these patches one by one.
Send a series covering the whole of the irqchip subsystem, once
you have looked at all the drivers.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2023-01-02 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 12:13 [PATCH] irqchip: Fix refcount leak in platform_irqchip_probe Miaoqian Lin
2023-01-02 12:20 ` Marc Zyngier [this message]
2023-02-05 11:29 ` [irqchip: irq/irqchip-next] " irqchip-bot for Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa4699cc0b1b17943d4c67e53c432a4@kernel.org \
--to=maz@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox