public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Duda, Sebastian" <sebastian.duda@fau.de>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
	ralf.ramsauer@oth-regensburg.de,
	wolfgang.mauerer@oth-regensburg.de
Subject: Re: get_maintainers.pl subsystem output
Date: Fri, 19 Jul 2019 09:54:31 +0000	[thread overview]
Message-ID: <6fa4aa44f343616459b17054197d0a22@fau.de> (raw)
In-Reply-To: <5a468c6cbba8ceeed6bbeb8d19ca2d46cb749a47.camel@perches.com>

On 2019-07-19 08:50, Joe Perches wrote:
> On Fri, 2019-07-19 at 07:35 +0000, Duda, Sebastian wrote:
>> Hi Joe,
>> 
>> I'm conducting a large-scale patch analysis of the LKML with 1.8 
>> million
>> patch emails. I'm using the `get_maintainer.pl` script to know which
>> patch is related to which subsystem.
> 
> The MAINTAINERS file is updated frequently.
> 
> Are you also using the MAINTAINERS file used
> at the time each patch was submitted?

Yes, for each patch we use the MAINTAINERS file from the current (by the 
time the patch was submitted) release (candidate).

>> I ran into two issues while using the script:
>> 
>> 1. When I use the script the trivial way
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ,
>> drivers/media/i2c/adv748x/
>>      Kieran Bingham <kieran.bingham@ideasonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@kernel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@vger.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@vger.kernel.org (open list)
>>      Maintained,Buried alive in reporters
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST
>> 
>> the output is hard to parse because the status `Maintained` is 
>> displayed
>> only once but related to two subsystems.
>> 
>> I'd prefer a more table like representation, like this:
>> 
>>      Kieran Bingham <kieran.bingham@ideasonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),linux-media@vger.kernel.org (open
>> list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X
>> DRIVER,Maintained
>>      Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer:MEDIA 
>> INPUT
>> INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),Maintained
>>      linux-kernel@vger.kernel.org (open list),THE REST,Buried alive in
>> reporters
>> 
>> 
>> 2. I want to analyze multiple patches, currently I am calling the 
>> script
>> once per patch. When calling the script with multiple files the files
>> output is merged
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ','
>> drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
>>      Kieran Bingham <kieran.bingham@ideasonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@kernel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@vger.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@vger.kernel.org (open
>> list),platform-driver-x86@vger.kernel.org (open list:ACPI WMI DRIVER)
>>      Maintained,Buried alive in reporters,Orphan
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST,ACPI WMI DRIVER
>> 
>> I'd like to run the script with all files but separated output, like
>> this:
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ','
>> --separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
>>      Kieran Bingham <kieran.bingham@ideasonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@kernel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@vger.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@vger.kernel.org (open list)
>>      Maintained,Buried alive in reporters
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST
>> 
>>      platform-driver-x86@vger.kernel.org (open list:ACPI WMI
>> DRIVER),linux-kernel@vger.kernel.org (open list)
>>      Orphan,Buried alive in reporters
>>      ACPI WMI DRIVER,THE REST
>> 
>> 
>> My Questions are:
>> 1. How can I make get_maintainer's output to be more table-like?
> 
> I suggest adding --nogit --nogit-fallback --roles --norolestats

Unfortunately, this doesn't change the output:
     $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
     Kieran Bingham <kieran.bingham@ideasonboard.com> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@kernel.org> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),linux-media@vger.kernel.org (open list:ANALOG DEVICES INC 
ADV748X DRIVER),linux-kernel@vger.kernel.org (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

     $ scripts/get_maintainer.pl --subsystem --status --separator , 
--nogit --nogit-fallback --roles --norolestats 
drivers/media/i2c/adv748x/
     Kieran Bingham <kieran.bingham@ideasonboard.com> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@kernel.org> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),linux-media@vger.kernel.org (open list:ANALOG DEVICES INC 
ADV748X DRIVER),linux-kernel@vger.kernel.org (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

>> 2. How can I make get_maintainer.pl to separate each file's output?
> 
> Run the script with multiple invocations. once for each file
> modified by the patch.

This is the way I'm doing it right now but this is very slow. I thought 
calling the script only once for many files could speed up the analysis.

Thank you
Sebastian

  reply	other threads:[~2019-07-19  9:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  7:35 get_maintainers.pl subsystem output Duda, Sebastian
2019-07-19  8:50 ` Joe Perches
2019-07-19  9:54   ` Duda, Sebastian [this message]
2019-07-19 14:31     ` Joe Perches
2019-07-23  7:29   ` Duda, Sebastian
2019-07-23  8:42     ` Lukas Bulwahn
2019-07-23 11:18       ` Joe Perches
2019-07-23 13:25         ` Lukas Bulwahn
2019-07-23 13:33           ` Joe Perches
2019-07-23 11:54     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fa4aa44f343616459b17054197d0a22@fau.de \
    --to=sebastian.duda@fau.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=ralf.ramsauer@oth-regensburg.de \
    --cc=wolfgang.mauerer@oth-regensburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox