Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Krzysztof Kozlowski
2026-04-10T07:41:37Z

On 10/04/2026 09:30, Takashi Iwai wrote:
> On Fri, 10 Apr 2026 09:11:39 +0200,
> Krzysztof Kozlowski wrote:
>>
>> On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
>>> On 31/03/2026 10:20, Takashi Iwai wrote:
>>>> On Tue, 31 Mar 2026 09:54:05 +0200,
>>>> Lei Huang wrote:
>>>>>
>>>>> From: Lei Huang <huanglei@kylinos.cn>
>>>>>
>>>>> Fix checkpatch code style errors:
>>>>>
>>>>> ERROR: else should follow close brace '}'
>>>>> #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>>>> + }
>>>>> + else
>>>>>
>>>>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>>>>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
>>>>
>>>> Thanks, applied to for-next branch.
>>>
>>> I hope you dropped the fake Fixes tag. Or at least give people chance to
>>> review it.
>>
>> I see you entirely ignored all the comments about fake bug being fixed here.
>
> I saw your comments, but I have a different opinion.
> In the case of HD-audio code where the code change happens very
> actively and quite often backported to stable trees, a change like
> this would block the further backports if missing. With a hint of

No, it would not. Commits marked for backports can even mention
dependencies.

> Fixes tag, the change of the code change can be tracked more easily,
> hence it's still worth to have.

Fake fixes tag is not the solution for that. It adds effort on stable
team for no gain, it adds work on people evaluating backported commits
for no gain.

BTW, since I was looking at your tree - you have contributions from
songxiebing@kylinos.cn which does not follow requirements for a *known
identity*. IOW, it does not pass DCO requirements and should not be
accepted.

Best regards,
Krzysztof