Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Takashi Iwai
2026-04-10T08:10:34Z

On Fri, 10 Apr 2026 10:03:12 +0200,
Krzysztof Kozlowski wrote:
>
> On 10/04/2026 09:46, Takashi Iwai wrote:
> >
> > It actually helps a lot on distro side, judging from my long
> > experience of backporting (literally) million of patches for openSUSE
> > / SUSE kernels.
> >
> >> BTW, since I was looking at your tree - you have contributions from
> >> songxiebing@kylinos.cn which does not follow requirements for a *known
> >> identity*. IOW, it does not pass DCO requirements and should not be
> >> accepted.
> >
> > Do you mean the form
> > Signed-off-by: songxiebing <songxiebing@kylinos.cn>
> > ?
> >
> > The name spelling without space is pretty normal in Chinese.
>
> It is a copy of email username.

... and the username shows the real name in this case :)

> I am no expert, but usually Latin
> transliterations have differences from usernames (and Google confirms
> that space is expected for transliteration, although Google is no expert
> either), so this looks like semi-configured Git.

Yeah, it's possible, but also it's a common pattern, too.

Strictly speaking, it's rather a mistake, and I'm no fan of that
style, too. OTOH, since it's relatively broadly used and can serve
for denoting the known identity, at least, I took as is.

thanks,

Takashi