From: David Laight <David.Laight@ACULAB.COM>
To: 'Matthew Wilcox' <willy@infradead.org>,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yuqi Jin <jinyuqi@huawei.com>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: RE: [PATCH] fs: Optimized fget to improve performance
Date: Thu, 27 Aug 2020 13:07:33 +0000 [thread overview]
Message-ID: <6feef2f0b6ed4df99e66c8325c8e66ae@AcuMS.aculab.com> (raw)
In-Reply-To: <20200827123040.GE14765@casper.infradead.org>
From: Matthew Wilcox
> Sent: 27 August 2020 13:31
> On Thu, Aug 27, 2020 at 06:19:44PM +0800, Shaokun Zhang wrote:
> > From: Yuqi Jin <jinyuqi@huawei.com>
> >
> > It is well known that the performance of atomic_add is better than that of
> > atomic_cmpxchg.
>
> I don't think that's well-known at all.
Especially since on (probably) every architecture except x86
atomic_add() is implemented using atomic_cmpxchg().
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-08-27 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:19 [PATCH] fs: Optimized fget to improve performance Shaokun Zhang
2020-08-27 12:30 ` Matthew Wilcox
2020-08-27 13:07 ` David Laight [this message]
2020-08-27 14:28 ` [NAK] " Al Viro
2020-08-28 11:04 ` Will Deacon
2020-08-31 1:43 ` Shaokun Zhang
2020-08-31 3:21 ` Al Viro
2020-09-01 9:29 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6feef2f0b6ed4df99e66c8325c8e66ae@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=jinyuqi@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox