From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+99ShvYKlIBCLnxxPvqAts7CLFovhLs5LliapqcW8yYE2qaTNmth6nOtweFIOKWX2A018Z ARC-Seal: i=1; a=rsa-sha256; t=1523997619; cv=none; d=google.com; s=arc-20160816; b=dCnDgDVniurAAtWwttZCgpCKs4T5OEcbilbbX7aZqyH01LuZ8XnMIUgicxZopRM23+ rDJ5lOzhQicZRl8pQkgOcAfnh4hZIL72e7eUaMbrpICXTXuawFBn+roE2/Zwx8v6Mp+E 3FLWCExo1FS1Zlcy+t4Vh6pzVYpD8IT9B6nzbGxDP6RIdIM0UIga2C6Iz5X7RXFevfqa ss13Oc7OAQLiM/vghUi6A+HaGCik69hMxCLmAhLMF83rFT/7CiRVOnd2jrv5WHcJONsP lMPgxBxwsrDMiqzQKNsedeMsTbSUMsRwW8+fzt2+cSqk6bomag6ecfOD7ost5MHwYMfD zT+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject :arc-authentication-results; bh=8dKiAjTqAeM1JoS9pexs9ZVVrCd277n9FgfCkawzBqE=; b=hbeUO3XgICz3ayg/V6oy2jdR/CsV/W9y4ocexnfQm/joLhyYhFADcWUkLkVT2gcsUQ yONcTQTTDrxNGlwhH7Aeox0WBuVYauFiUToYJJBC4FGSbn7Bwsog/v0xjYXQT1ldLv4X pjDKAgkUGR4FObdUP+hfPmI0rvaTxDYAd4XL/OEPWlNPcDE3/+Ory/1tLYOQF0Ki8Oaw xEnYTGdatjQfn+4kENCFwACX23LC1+PZsVZKdbSb4/gNDproBPqEpwAdOg+NsEfP87TL DlIkDGffB+6pESsBFUTYDeh1GVln/bCR+YW8MJzOCvJym1hIM56tKjy/3Zgw+srWcY6u isLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="192266805" Subject: Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers From: Jae Hyun Yoo To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-8-jae.hyun.yoo@linux.intel.com> <20180416181423.t4vf7sugv6z3aw5h@rob-hp-laptop> <287e0fd9-b631-2602-2785-7b8aaed7a6b9@linux.intel.com> Message-ID: <6ff697e8-cd20-e551-da13-b614cc39f900@linux.intel.com> Date: Tue, 17 Apr 2018 13:40:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <287e0fd9-b631-2602-2785-7b8aaed7a6b9@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597385139320717723?= X-GMAIL-MSGID: =?utf-8?q?1598027327663681715?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote: > On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote: >> On 4/16/2018 11:14 AM, Rob Herring wrote: >>> On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: >>>> This commit adds dt-bindings documents for PECI cputemp and dimmtemp >>>> client >>>> drivers. >>> [...] >>>> +Example: >>>> +    peci-bus@0 { >>>> +        #address-cells = <1>; >>>> +        #size-cells = <0>; >>>> +        < more properties > >>>> + >>>> +        peci-dimmtemp@cpu0 { >>> >>> unit-address is wrong. >>> >> >> Will fix it using the reg value. >> >>> It is a different bus from cputemp? Otherwise, you have conflicting >>> addresses. If that's the case, probably should make it clear by showing >>> different host adapters for each example. >>> >> >> It could be the same bus with cputemp. Also, client address sharing is >> possible by PECI core if the functionality is different. I mean, >> cputemp and dimmtemp targeting the same client is possible case like >> this. >> peci-cputemp@30 >> peci-dimmtemp@30 >> > > Oh, I got your point. Probably, I should change these separate settings > into one like > > peci-client@30 { >     compatible = "intel,peci-client"; >     reg = <0x30>; > }; > > Then cputemp and dimmtemp drivers could refer the same compatible > string. Will rewrite it. > I've checked it again and realized that it should use function based node name like: peci-cputemp@30 peci-dimmtemp@30 If it use the same string like 'peci-client@30', the drivers cannot be selectively enabled. The client address sharing way is well handled in PECI core and this way would be better for the future implementations of other PECI functional drivers such as crash dump driver and so on. So I'm going change the unit-address only. Thanks, Jae