* [PATCH v2] bus: fsl-mc: Check return value of platform_get_resource()
@ 2025-08-25 9:34 Salah Triki
2025-08-25 15:46 ` Ioana Ciornei
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2025-08-25 9:34 UTC (permalink / raw)
To: Ioana Ciornei, Markus Elfring, Christophe Leroy, linuxppc-dev,
linux-kernel
Cc: salah.triki
platform_get_resource() returns NULL in case of failure, so check its
return value and propagate the error in order to prevent NULL pointer
dereference.
Fixes: 6305166c8771 ("bus: fsl-mc: Add ACPI support for fsl-mc")
Cc: <stable@vger.kernel.org>
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
Changes in v2:
- Add Fixes and Cc tags, as suggested by Markus Elfring and Christophe
Leroy.
- Remove blank line before the if statement, as suggested by Markus
Elfring.
- Replace ENODEV with EINVAL, as suggestd by Christophe Leroy.
drivers/bus/fsl-mc/fsl-mc-bus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index 7671bd158545..cd83cd564736 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -1105,6 +1105,9 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
* Get physical address of MC portal for the root DPRC:
*/
plat_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!plat_res)
+ return -EINVAL;
+
mc_portal_phys_addr = plat_res->start;
mc_portal_size = resource_size(plat_res);
mc_portal_base_phys_addr = mc_portal_phys_addr & ~0x3ffffff;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] bus: fsl-mc: Check return value of platform_get_resource()
2025-08-25 9:34 [PATCH v2] bus: fsl-mc: Check return value of platform_get_resource() Salah Triki
@ 2025-08-25 15:46 ` Ioana Ciornei
0 siblings, 0 replies; 2+ messages in thread
From: Ioana Ciornei @ 2025-08-25 15:46 UTC (permalink / raw)
To: Salah Triki; +Cc: Markus Elfring, Christophe Leroy, linuxppc-dev, linux-kernel
On Mon, Aug 25, 2025 at 10:34:35AM +0100, Salah Triki wrote:
> platform_get_resource() returns NULL in case of failure, so check its
> return value and propagate the error in order to prevent NULL pointer
> dereference.
>
> Fixes: 6305166c8771 ("bus: fsl-mc: Add ACPI support for fsl-mc")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - Add Fixes and Cc tags, as suggested by Markus Elfring and Christophe
> Leroy.
> - Remove blank line before the if statement, as suggested by Markus
> Elfring.
> - Replace ENODEV with EINVAL, as suggestd by Christophe Leroy.
>
> drivers/bus/fsl-mc/fsl-mc-bus.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index 7671bd158545..cd83cd564736 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -1105,6 +1105,9 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
> * Get physical address of MC portal for the root DPRC:
> */
> plat_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!plat_res)
> + return -EINVAL;
> +
> mc_portal_phys_addr = plat_res->start;
> mc_portal_size = resource_size(plat_res);
> mc_portal_base_phys_addr = mc_portal_phys_addr & ~0x3ffffff;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-25 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-25 9:34 [PATCH v2] bus: fsl-mc: Check return value of platform_get_resource() Salah Triki
2025-08-25 15:46 ` Ioana Ciornei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).