From: David Howells <dhowells@redhat.com>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] afs: Fix dangling folio ref counts in writeback
Date: Fri, 16 Jun 2023 23:30:43 +0100 [thread overview]
Message-ID: <700316.1686954643@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230607204120.89416-1-vishal.moola@gmail.com>
Vishal Moola (Oracle) <vishal.moola@gmail.com> wrote:
> if (skips >= 5 || need_resched()) {
> *_next = start;
> _leave(" = 0 [%llx]", *_next);
> + folio_batch_release(&fbatch);
This should go before the _leave().
> return 0;
> }
Looks okay otherwise.
David
prev parent reply other threads:[~2023-06-16 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 20:41 [PATCH] afs: Fix dangling folio ref counts in writeback Vishal Moola (Oracle)
2023-06-07 20:41 ` [PATCH] afs: Fix waiting for writeback then skipping folio Vishal Moola (Oracle)
2023-06-09 0:50 ` Andrew Morton
2023-06-16 22:43 ` David Howells
2023-06-16 23:22 ` Andrew Morton
2023-06-16 23:26 ` David Howells
2023-06-16 22:43 ` David Howells
2023-06-16 22:30 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700316.1686954643@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox