From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbcF2GCQ (ORCPT ); Wed, 29 Jun 2016 02:02:16 -0400 Received: from mout.web.de ([212.227.15.4]:49651 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbcF2GCO (ORCPT ); Wed, 29 Jun 2016 02:02:14 -0400 From: Alexander Stein To: Arnd Bergmann Cc: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, "devicetree@vger.kernel.org" , Linus Torvalds , "Linus Walleij (linus.walleij@linaro.org)" Subject: Re: Re: linux-next: Tree for Jun 27 (pinctrl && !CONFIG_OF) Date: Wed, 29 Jun 2016 07:54:29 +0200 Message-ID: <7003426.R6hER1qrYx@ws-stein> User-Agent: KMail/4.14.10 (Linux/4.6.0-gentoo; KDE/4.14.20; x86_64; ; ) In-Reply-To: <3990550.tEk9cGVQPW@wuerfel> References: <20160627163939.20e454d5@canb.auug.org.au> <2044946.aGLaEK2W6I@ws-stein> <3990550.tEk9cGVQPW@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iZnt+S83wsMTfmVMyRZn/DPFqcRKjpWTW9G9NKdRYfdcqTtSB5k S84yXW/ctwymcjjEoHEZDyK9n+6n20OhQTJNPgBisRvgzA3wi4qrhZ5RBZLU2QV+G5n7LNM ssskLLBlqynAFjIymb5rto9c3dSSowIK+H5EsSPyEFf/c1TVUfqnggwt/53M9oyZSylarqg tRkm6Stenrokej/cJKYvA== X-UI-Out-Filterresults: notjunk:1;V01:K0:PK6MyReqHps=:k9ndMp0O7ND0nWmSxK+995 iFvGuYJoLSRGaqiR2fsEGf/1P7d2fDBaMpKZDmzMEy3gHaIyi5sfjQX86d5NiirKiyvjCV3A1 j/07uVkllFnpSiVYcewJHeu5U/8GvxteF9tdrX939BXmH7r3EY43ilv60rLado6oEU9chK0i5 viUxPuSM3UUHcNX4rHz0rmrPigJ/LlCQJdB14ETqN8VpZQDJDjCcCIUXwLnS2VI+48cX18/av 6QOPytXj+JlvzNOxEkt1iZKvcR4WWbVKZEQrBKm0BtkAe3oGzvaxO8TlRbMt25wvIjjT77AN4 uCWjOZvh2//9q9eqxou+Cb9ZwjLQYEGeKsVPJuluBuHaDolVKvnsXMQ0uKHjHRvfirxiu5gau uPl3Jb+4n2OP4GtO4t3vPmHti6yupNA9LlXHQPLPo60dEASEPScBnzYmfWw6n5496+oHU1MZ/ XI08KACuxKnFpCPZ9KndufYz0YT46kwA7DeHncY4NriB0R+uv6wOl+i2CsJUtzkoqsBzTPI42 KE6eQpsOIjmxhRI5ON6wtLIEdz1j5/wh/hDXvj8JsFOQ4Wop3C25v14UKauuGtiRrZSEDvK5h bCERjWTlGQ9DPhtU5ZrgOrmEv8MnUAeBjUcQHAKRWgCHF8Ncujdq61C0omffmS2Nw2KPp7V10 cWpK/NWQ7VbW1Y0elqkSBEii8wm50yHaaBV1uYEc7sKYHDLG3mdLD/g4cDGXCPQY6G217PKJ+ t0G1MjV7IA9J2BD3OMOj9b+Szs9Spllsnj4zYqoriXB4QkOkDjHbMZc2SIhw9jL3rc4EyHGIh +vEGf8B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 28 June 2016, 10:37:52 wrote Arnd Bergmann: > > > I think the commit should just be reverted, it clearly breaks > > > stuff, and whatever needs it can be fixed in a better way. > > > > Why not depend PINCTRL_IPROC_GPIO on CONFIG_OF as Randy stated > > pinconf_generic_dt_node_to_map_pin and friends are only present if CONFIG_OF > > is enabled. Depending on OF_GPIO only is enough under the assumption a) you > > made below. > > Also what about providing dummy implementation for those missing function in > > case CONFIG_OF is disabled, my preference as more code can be compile tested. > > > > > Specifically, we have three ways that the OF_GPIO symbol > > > is used: > > > > > > a) it is implicitly enabled when both GPIOLIB and OF are turned on > > > > or if COMPILE_TEST is enabled > > > > I think a problem in this and possibly other cases is that COMPILE_TEST > > loosens the Kconfig dependencies to some degree. How to proceed? Allow compile > > testing drivers only if some optional settings are enabled? > > I think we can start by reverting your patch: for compile-testing we can > always enable CONFIG_OF these days, which will also turn on OF_GPIO. My intention was to compile test (device tree) drivers also without CONFIG_OF which is disabled by defconfig default on arch/x86/configs/* > Compile-testing drivers that need OF_GPIO while OF is disabled makes > no sense to me, it's not a configuration that anybody can ever use > and it adds no build coverage. That seems sensible. If we can agree that anyone who wants to compile test drivers has to enable CONFIG_OF even it is not needed for the current configuration. Best regards, Alexander