From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: "Liang, Kan" <kan.liang@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf: Add missing newline at end of file
Date: Fri, 8 Apr 2022 22:45:16 +0800 [thread overview]
Message-ID: <70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com> (raw)
In-Reply-To: <CO1PR11MB4803640A785DF199D0496017E8E49@CO1PR11MB4803.namprd11.prod.outlook.com>
On 4/5/2022 9:59 PM, Liang, Kan wrote:
>
>> On Mon, Jun 17, 2019 at 6:00 PM Arnaldo Carvalho de Melo
>> <arnaldo.melo@gmail.com> wrote:
>>> Em Mon, Jun 17, 2019 at 04:47:25PM +0200, Geert Uytterhoeven escreveu:
>>>> "git diff" says:
>>>>
>>>> \ No newline at end of file
>>>>
>>>> after modifying the files.
>>> Auto generated files, IIRC, Andi, Kan, Sukadev?
>> The auto-generated files have been updated, the issue still exists.
>>
> It seems like a converter tool issue.
>
> + Zhengjun
>
> Zhengjun, could you please take a look?
>
> Thanks,
> Kan
It only happened for perf core event files. Add "\n" at the end of the
perf core event file, then the issue is fixed.
I have updated the event convert tool
https://github.com/intel/event-converter-for-linux-perf , then the next
time uses the convert tool to generate perf events, the issue will be
disappeared.
--
Zhengjun Xing
next prev parent reply other threads:[~2022-04-08 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:47 [PATCH] perf: Add missing newline at end of file Geert Uytterhoeven
2019-06-17 16:00 ` Arnaldo Carvalho de Melo
2022-04-05 9:48 ` Geert Uytterhoeven
2022-04-05 13:59 ` Liang, Kan
2022-04-08 14:45 ` Xing Zhengjun [this message]
2022-04-10 9:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=arnaldo.melo@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox