Re: [PATCH v3] sched/topology: Enable topology_span_sane check only for debug builds

K Prateek Nayak
2025-02-07T02:46:15Z

Hello Valentin,

On 2/6/2025 8:54 PM, Valentin Schneider wrote:
> [..snip..]
>> So circling back to my original question around "SDTL_ARCH_VERIFIED",
>> would folks be okay to an early bailout from topology_span_sane() on:
>>
>> if (!sched_debug() && (tl->flags & SDTL_ARCH_VERIFIED))
>> return;
>>
>> and more importantly, do folks care enough about topology_span_sane()
>> to have it run on other architectures and not just have it guarded
>> behind just "sched_debug()" which starts off as false by default?
>>
>
> If/when possible I prefer to have sanity checks run unconditionally, as
> long as they don't noticeably impact runtime. Unfortunately this does show
> up in the boot time, though Steve had a promising improvement for that.
>
> Anyway, if someone gets one of those hangs on a
>
> do { } while (group != sd->groups)
>
> they'll quickly turn on sched_verbose (or be told to) and the sanity check
> will holler at them, so I'm not entirely against it.

If you're game, I'm too!

I just put it out there in case folks had any strong feelings against
this on other arch but that doesn't seem to be the case and we all love
a simple solution :)

>
>> (Sorry for the long answer explaining my thought process.)
>>
>>>
>>> That I can't remember, sorry :/
>>
>> --
>> Thanks and Regards,
>> Prateek
>

--
Thanks and Regards,
Prateek