From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbdKAI5W (ORCPT ); Wed, 1 Nov 2017 04:57:22 -0400 Received: from mout.web.de ([212.227.15.14]:54413 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbdKAI5T (ORCPT ); Wed, 1 Nov 2017 04:57:19 -0400 Subject: Re: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi() To: Simon Horman , linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Bjorn Helgaas , Laurent Pinchart , LKML , kernel-janitors@vger.kernel.org References: <20171101081831.ssnuqp5b75lbfu5p@verge.net.au> From: SF Markus Elfring Message-ID: <7047eb7a-cf93-6a56-08db-a5e8bedbfc57@users.sourceforge.net> Date: Wed, 1 Nov 2017 09:57:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171101081831.ssnuqp5b75lbfu5p@verge.net.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ILKX6mt0bv48Ieje9qYQk8e872kj3L8F8AIcKHtf16crRN1DYMX Wr1paJFMC0tRaDnRveAJ/8aycDTZ01YU8ghxz/ehkD8vD5dkvZm8fVQxPdtrZfzXhIIXr7U w4ZLEHaOP/1Z36oN7EYDBRrKMX/Ut7ZcGNORd3plFjJpo8IStPr4xncQvOxUT9nt1nKMHeu D7YrOeCFfHQPFiek19Qdw== X-UI-Out-Filterresults: notjunk:1;V01:K0:kwq6+IH4vDg=:oCLh5Xj7YNP24daTXtTcfF n6u3beZVreu6aM6BeoTpjdcDXE0ZsAbzp7i9qY86BKaiRGGNQdw634waOKoSUym8/SMmRc/mM o7Z9py0YO9mudTnAypiOctVIIy6G8uhuWV87GE98j81c2WPklpEwAx97Xard3E1LIoESYRvdP sK+mHcS27HYSw2Z2UUTvim5dL8NNZVLRgziEdIgqLgTlUVGDd7IClybzkSyfJDsSvcINuVVm9 PZZEdwhnuvi5sqWclmveBec34FR7FT4EvnwyC2TqMKK+hGmZE2zpwp+VqfY1Ky+OrcoJI0Kdd f72iwpq9uf9+RKmULrAKg+9hRs0GuSsaKUiXX0zDbz3Z3MNoWa27L9GjPZ2h2ss4d5jlvWOnj bZqVuZiDMPQ6Hc/Z6TkPz0m5vJ7Rn3nUK3UP/2VqS6rnkMUZCLpVhtooJL+xPj8Fr6ChEJv6Y MbLRiXnn3vWJxERU7g8vLwyEJ1LaBxk1TYagDx/aSwgw9LIsGrJU9LXnZIuQ6gtV/W5+KGLHb 0fVdC7d4zxxkcMg2ZXKaJpwcLSB3GK5y5XhtH2FnEnCSmIkyNiCNiP5gYLv5qkhpaTLTNs17s F+FTz+Tyoa6Rzi6aFWIfeaq3GXPEHg4hFtpI0/KHXkExPGqJaMq45uYl0qh2KNuxwP5qHtThx bYzbgOw8h+K1l5GjXJWzt36TfzSgRSGwv3d8cn/X+nzSLwsl+cyzEeFySPN3TVkgkyG7QfYGu 5dlCtSxM2LX/auI7hA2YtI/LinpXPzAhucH81IqruDitL8bkRoobh3lvOKTxBgD/lyQgehj8J 8ZbKOKfTgpcXa9ZD449OrPsn4MZ1dgRq0koUxPZwzjmUAuYslY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This is fine by me Thanks for another bit of change acceptance. > except that the change in the name of the goto label seems spurious. I am curious if the popularity of a jump label like “err” will decrease (in the Linux source files) over time. > But if you really want to change it then as it is an error path > I should suggest it describe that its an error and what unwinding > is done, f.e. err_remove_domain. * Do you get such a kind of information only when the prefix “err_” is added to this identifier? * Do you prefer to stress the “domain removal” (or the shown error message) in the label? Regards, Markus