From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753797AbdHQUOo (ORCPT ); Thu, 17 Aug 2017 16:14:44 -0400 Received: from mout.web.de ([212.227.17.11]:62059 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbdHQUOm (ORCPT ); Thu, 17 Aug 2017 16:14:42 -0400 Subject: [PATCH 2/3] orangefs: Use kcalloc() in orangefs_prepare_cdm_array() From: SF Markus Elfring To: Martin Brandenburg , Mike Marshall , kernel-janitors@vger.kernel.org Cc: LKML References: <6802994a-a537-2e00-e7d8-c1b822879f76@users.sourceforge.net> Message-ID: <705dd4fa-3daf-08fb-23c8-1888b67bc1ce@users.sourceforge.net> Date: Thu, 17 Aug 2017 22:14:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6802994a-a537-2e00-e7d8-c1b822879f76@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:P8RpF8+xiaPm9n4UelHlZ33pQe9f86XvLOotzYCSU1ZkxQ0ihjb bMOw1fM2Xnkupu2RCmfQEo7kYtZhNbCrhDX9t6rjvMRLxviAr8eN+yQokgDshckQkfq1wLR FhGXXFvDzIvsNaQ51mfr+/iIhiDzoRXYlbCKIcOj/7wsr07bZEWXX5ie7muTXJKaibvUkSR 8AAbwgBuqiiAtZk1JghkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:iQd0cenyFKc=:giNsam0ANJbBsuhJTc9roC 7C1x1wCDxLzQ5h5m93TgqTeSWOBTM4WvROfpF7sNWw33aJl9DkUM/CRJGQZsVe1scPknvFTtr enaD7O9QU6KX8SmiGXrwYvOREQp8bKQ5nQ3sLJmrVS4/CA0q9HjjYzbLacs7D2clZ4EqgUf/3 to6yQCKteVNWUNdhT+nLRSgOll1nPTk+z+1G+8/v+jVK5D25tkuiD9k4TERhEIqwUTae27i0p OEUDoETCTcyFBrOlVeD72XWqsAq5WJqiQLeFemflSFBxvElKFSjz7dawxrhl48VOju8NU0Twg sxOvfZkf1yBqi8WFY/o08rNRlCWbS1E1i1mLEJo+rMduhtckJL9kugJqOKD+wowSJeUpVu2gI KU91Q88yh3j6z3TRcICe6HI/ZLtmlnHQuq8HRuQn87IuVdQqzuZEDgjPs39JqDY3yARGoWeLx TSau3zxcNwdH25ipwFFUllbE3mbJtbWWiN7vCyOJjEvgJfGORdbC8KEeVZWowkE0CPojbcby/ OfMvp3qO55mXiWyxBpyLOtZ2hyfh8tTIupJyzDrj6iCV31zriC16QC0kP9oc/mlFrbi2HOqs/ IoqUiVo48lt4BAW/Myqe3qS5VuRNYxwapdVS5gW9OUSVaQM35hWjT/dtDUXhUreVKJNm+9E8E 59dDXdAPsU1GOUwWOsvYqMhk6C1HSXDAeoZamj0Em0IJrI8UBionj5n0xrTjpVQUawqVgtfOh y1V4uNo7BDTTHQKz/jVv26kOrlAH2SALf+YXvCD2PQT4+cLed/H7pxUqN8OA7NepJP55BanPN PvEwdFShjHN1sjVd3HZ4Kebfw2xJ+yD05J7JkqRTQzsaNNWRw8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 17 Aug 2017 21:18:01 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- fs/orangefs/orangefs-debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index 93fe8f8e60f1..5f59917fd631 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -571,7 +571,5 @@ static int orangefs_prepare_cdm_array(char *debug_array_string) goto out; } - cdm_array = - kzalloc(cdm_element_count * sizeof(struct client_debug_mask), - GFP_KERNEL); + cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL); if (!cdm_array) { -- 2.14.0