From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756751AbdJKOYC (ORCPT ); Wed, 11 Oct 2017 10:24:02 -0400 Received: from mail-sn1nam02on0068.outbound.protection.outlook.com ([104.47.36.68]:26591 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751620AbdJKOX7 (ORCPT ); Wed, 11 Oct 2017 10:23:59 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.1 12.1/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171004131412.13038-13-brijesh.singh@amd.com> <20171007010607.78088-1-brijesh.singh@amd.com> <20171007184049.jrbxebb4jlciu3hj@pd.tnic> <20171011141949.z4blmu5wy5sooq4p@pd.tnic> From: Brijesh Singh Message-ID: <70607e4a-b2e1-7b0a-a9d1-0d7f52c3910a@amd.com> Date: Wed, 11 Oct 2017 09:23:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171011141949.z4blmu5wy5sooq4p@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM3PR12CA0056.namprd12.prod.outlook.com (10.161.151.24) To CY1PR12MB0152.namprd12.prod.outlook.com (10.161.173.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 378db3cb-63c8-452c-b865-08d510b3b53d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0152; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;3:V9fpKIxOPgB7hXaTPk0aQPtfue+gPMKHnqUbD1hJWYXQoW5USmW+3Ledm6szvCZ9IKQ6TeULN7P/wka4xyBOWsyD59ILcXuEebc5jFAMxpxCj1gfHhUkSReIuLtv72SjWhe3rE6ukoMsX7P2rDeFDG57Ge8lUaq11SCSUiILNoUAwbEYMII6jxH3KUx0C0XCiHKn9+VElOg7stpyemVwjw88GZHJhLF8GNHW70n1xaeftQN98bHr1T76hrv73NUg;25:N8U43h88cPPRu76uKovkFbUDomZw+WeUPJmVK2MwKlnWb8OUxxkOIquAqmY2JE0LN13ROS9N77SekVt4W2bmYVuLD9oeCPly6gti9ipBPv7B+o9Hb1joILLN/a2YAKdEdt0gVruPNBdYgShPcRdby3WQwCAb/7dzNgqLvABl2SPEqWlQ3qT7t0QKJCU9fzQFs6BU91sSq8vlqQXqefdd6GWQ2+8woo1FvZPxSrC/LlRO1cz+B1uy1DQs8WoM1bMG626OCWVFHq+kmLuF8AWb7C0MUE0RpOpGrTMsZIKIgQoRf6kNO3tf7amNLkzqYqzgvA506lqFL0KHpbsSaLJ0zg==;31:X/KDwN2ahAjepeWzTzfnsYgRYu+Pk17yVMA0GN3E0yvCHqTscoW/STJkZ/IV99McdBZyLCjfcLnX3skrZdaNwEmuD7dzedf/lJw0qFzubWEHTLPwKCimDA9V42pAdIHMVHyat+VuCzE97NN6acwwt2nIJ3u6aXnSTlGl9Ea4kf90XDkBVPVF4a8q/vxRtafulLuwFoTxiT9lAXJ1nWb1rfFV2Wjd3x3CmXRRXsuYbdg= X-MS-TrafficTypeDiagnostic: CY1PR12MB0152: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:sjXfIBk+WlagEkpgqf/gIqJbk/QVv+BK09aC1tE661OKGD9nybKZDCKM4FO9x1wrfaurCr7UBYhAe5WPqaezK5x5W5B+Djg4W7cjRon1Ew0nJ3PSqSaNeEc+dQ5jwSR7xyyC5zQGL9RRxriI4vfQWgtYpcLxINBm0PJ/nx8B/Z9TPvZ4KiOSpFfwG706Wd5wixUOwBcojd3xVUCa9ZMVppaUHMcZkmWBRR3ojoMR0COOmys5cGMZULvGG6g16JUQIuLvhRZ3bCYcHKFCqSo1plXT2gQJ9Z9Gi9q1Id9kRsyvu17gbsJG72DTa9YrlPAztpbf6ii9a3kTBPLr+FBoWigBto2CAzLExd3IWB8FQyf82SS5RCeP2tPd9+jEuvmhc4bk2rB+jnwgW3pW/q3lCJpdRuqjCeptDsceOH5MPI/bBxzfp8qraBVLRwtPftKzLiCjSr0MPZxP224ywacnw2vuTqEt4sj8wZey99S83IcMly3tN9YqVBJofns0XPA+;4:l/WwvvXGDvxB8IWpaYwfFnTz9RDBJMd2Nh5UJz1RSc3oY3md0reKEJOkVIVb2zfCoCjdb3nabB3C1Sbgwt6LmUtlLC+7/OPM4JrZ9+gfop/jAMDmycTeJbCfp6SoQZSSgS+iKEGXL5b07WSHPtPXTWLE+Kw8QF/9tZs+7xBpleFOAI10UgniSlCEEPXi9BihJ6Wjs0fPvl0iAQeygeoCboWj5lGrRutvsJ+5FiljxJuQ8I98c2rjz0dlxFU2WUP1 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0152; X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(376002)(346002)(189002)(5423002)(199003)(377454003)(24454002)(305945005)(47776003)(316002)(58126008)(6666003)(97736004)(5660300001)(106356001)(101416001)(65956001)(25786009)(66066001)(65826007)(65806001)(90366009)(53546010)(93886005)(8936002)(23676002)(50466002)(6916009)(2950100002)(81156014)(54906003)(81166006)(16576012)(83506001)(6486002)(77096006)(4326008)(16526018)(2870700001)(8676002)(3846002)(189998001)(6116002)(478600001)(31686004)(229853002)(53936002)(6246003)(31696002)(2906002)(7736002)(64126003)(105586002)(36756003)(33646002)(76176999)(54356999)(86362001)(50986999)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0152;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUyOzIzOmdTY1hrbk02TnhpZkZLZ29Ebko2Y2dxd2N2?= =?utf-8?B?YW5ndVViVUZ4Mmg3U0Fla2FaS0E0d0F4WjQzL3VPR3FBTmVreXhldHFudklL?= =?utf-8?B?ZGw1WGtCNmxRcHNicHlTaTUzSWM4ekNiUFFOMFVaNlBoNjBseEhXQ2YyVEdh?= =?utf-8?B?NE1nUm1KUTVJOEdkRG9tR1U0M21MNmNhM295YUJZNGRuZkVFdXBBSGxCMHdz?= =?utf-8?B?bTZUbnBNTFNSM0EwTWp4TU5DYnBCSjFJMWdDcXlVNXJjdU9RK3NSZUNwenNT?= =?utf-8?B?V3U3WFJUQ0IzZSsxVmpQWjgrVHRQRVJFNnhuV2ZjOVBiU0FUNGFBK2wwRUdQ?= =?utf-8?B?ZkY1UllGU3FMZXFGaGQ2anZyYXFFVmhlczA5UFhFVkdIWXAxL3dqWTlDclVF?= =?utf-8?B?clE4OWZ5dFZJdGkwdmp0Z0VxczRsM3JpazdBbktyaWFtaElNWFBGTFg2QWlj?= =?utf-8?B?RXFWUSswRXozNmVpcUdOWXEwUytCYVA0MTNqUFM0ZG0vS2NRQW51RjRjMFd0?= =?utf-8?B?MGZwZXFEZlBoaTNDK1h1TVJLVFpkQkZJLzc5MGJNY1RYQUowUk9xUnpEUTd4?= =?utf-8?B?ZTdOalZ1YXRSWTNmZlByMHFVT0FiTk8vczFLTkJPS1BIWGsyVm96Sitwek1X?= =?utf-8?B?ZXZlNHREWnljbDA2eUtaZ1RqY2I3TTFqVGw0cWNrT0FLckV0czIzMnJabzJi?= =?utf-8?B?VkcrWnJmVkNUWUZGSm91UmpPNWtqZGRES1dFaGd6SHE5aHlMWjl0SWkremd3?= =?utf-8?B?aVVhRGZRdTkvbExSOUljWGVaaEFxMlVIc0ZPeGdqU0pDSFVXUDd2eUUyYTRm?= =?utf-8?B?dmxkcTNzcVRXNXZ5Z3c0UnhQMHc5OFpUTG9STnVCNkkwYWk1NTNOcUc0TUFP?= =?utf-8?B?WHZrK0lkTFUwbnBqNGpRNllIWkZBbnN2Z0w0aU5IU1dNZ2lMY0ZiVTY0TFk1?= =?utf-8?B?OHUxMmxYVDN4WHZxQkhUaVF6TFFnZVhRQ2YwYTgwYzJWVmRPL1NQSnlMNGlP?= =?utf-8?B?NDlyU3pITHh6TkpsTFpHV0JvRnRHUXNHVktLbStGL3N3WDVKOFdUUjZMZ21B?= =?utf-8?B?endaU21LZzZ1SHZJQVNPaVFkVGU3Snh6MHY3ejk4WVZCV25xbUdnV1krYjA3?= =?utf-8?B?QXlCcGx3RDlQZEY1RHJ2Zk5JZjljUDk1dlZxRzBtMEF6citmdFdLSEQzaVhs?= =?utf-8?B?bUtZWWllOWlUa1FDeXJBUWJtNjcxZFViNjBxaW9idUhCeVd3QmtEVnljeCtJ?= =?utf-8?B?Tk93c0hLVHJiWFBJM2pLYk14OUhKQXNEQVAvajZPOW9pTFVETjFoMVg2ek5X?= =?utf-8?B?R0VKbkthSXdiejlBUDdsY0pMcG9sWUwzUFlzYXNaT3RFWFVNeFhsQmJDL3ZS?= =?utf-8?B?QWZnVm1DbkRHSEhKUy9RK2JmeThPa3VsM1lYcnBTQTAzL2NBbFhRR2NyT3hq?= =?utf-8?B?R0lJazJPa2lZVFY3WTJTcmczWURuOFpybGtQWERxS0xIbW93TW5ZVVVDWm9E?= =?utf-8?B?ZXRPL09odEJZNFRXS3IzeEp3ZHA3WENUNzQzK1duMTZTL3NFNEVXbVlsWDNj?= =?utf-8?B?SFdkV1F5VVFNZEsrRHJCYTJOQ0pqYjJsaGFvZUhQOUY1d2ZLV1pUbTdsNXd3?= =?utf-8?B?M2pldXJEZzd1TUo3aDJzVTYxaTdXTWV4dTVJZjBKNUx2d3IxNUZLTVJEbnNY?= =?utf-8?B?THRkR3FobzBuZnM5OThIRXRvVXRhQTJPZGNBMXJ4R0d2WlhuRkJYWXNabXJK?= =?utf-8?B?U1VBL1hlSEVDdnJTU2llR2ZwWnRGcXBDeTN5M3dUL2ttUDROQm8vSW1VcFF6?= =?utf-8?B?VVZVS3h3ODhOVHcwZTlUT3VXNTdLWVJMYTl4MGJqZm0veFJoQzZ3cTRJS3RD?= =?utf-8?B?bzV6T2lrYkh0ZVRiUnYzQnBrNVdUWFVFOUpZZm1oWmhpQ2NWbHZJVUlSSFI1?= =?utf-8?Q?7LVoH6r9XcErLw8aLhcCag7l7LN21Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;6:mLUAkHMvWEp6Kzikci78Tj4LL/BDqGiqYtj63Qwj0JgMDriUjJ1wW5k/0kAc7/6VKNseJrgYirxV9Hnrl6CCk78qGFM9sgyE1Hc0u+Yd8AKEsaSdlqnwNiyy4mal1YtDNvDrt3znvujxPrjbTCdkl2i5kw9j+QENvYMYtrogxX5Z5A0XKF89bgjAJK/ZahLfr078MZMvxUriqBmn/6Z2LH4MwPF+KA5bXGXLK4UEsLDS2vZ1tYI4+OlSYVpUnDvJcuicUWYQrksxOl8O5G5ir6TMg2cWg7DiJplDYxyib+WueCJPaKwokVha9GnGpt1kiLj+bL0Yv/S8eOgd3Bf+0w==;5:vYNObd4itvmdtj2N0lersviRIO3t0Hcc95Q+ngyaLDIXDmceUBaEWqvPg0QGzlgPdCrx8YLbcUf4w8fY3PvU9RNV2cHbczzepawpqwWImE7eNOVvAeSMXdtHzmCLWc7cdyh/R9al1LbXgkpj3iq0lQ==;24:gRB1Ke33R+1fEj0BnafZrLJqgxIGO15eS79+0Y+cUMpg8ipJL4rXxf7MTJlGuTAXXpWBEpYqJqKHbZ4UZVn/+Ew2TcX8jVahJGuQe5gCVT4=;7:x6MEH+ZIieM6lSF+ZnAAs/fVflL0h5a+eVg8QMYrdPBKWR88YFM7o9WSRnb0mrD2GNpauLxUaQYavVT4fgT5lU5c9jgYomkC7sIph4I2hoswvxZxNGVf5XfEXOFdqTqKNoBUvKr2EPbXt1EGdf36r1HuP3mVvE8f5wwfjckYtDwgxE8ao+neFT7uxQYjAjcGBA4roqeo4J/Bp2s0C/I11omHj3X9cGCZjDVQNCRaKEQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:5op9mN8PcxAZL3cy3U5uNqt+alF+4g1q3gEhCo4TX/qoWdzQ/bQjPk21R3bv9J33uhHwGhPdfNDs/wSovDNZ/1lER5NKHWeYjviCrq4mHFlTMZjNo4+1+pIrRNROxqKxNV/9SD9mxZ6HRYKp5Dwdnr3OcRo14sV3C1qPfTGcGeXE8B+WpFJXTvBsY/NbtMuucix8FfBPJ/oNQapce7KxO5nqlWzN7KMOVAo65aDnONQ8fj7u0SI0Bw+YpHFtRiBw X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 14:23:56.3704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 09:19 AM, Borislav Petkov wrote: > On Sun, Oct 08, 2017 at 08:30:47AM -0500, Brijesh Singh wrote: >> Basically we need some variable which is outside the per-device >> structure so that we don't end up creating multiple /dev/sev nodes. If >> needed, I think we can remove 'has_sev_fops' variable from struct >> psp_device if we decide to dynamic alloc 'struct miscdevice sev_misc' in >> struct psp_device. The 'has_sev_fops' is  mainly used in sev_exit(). If >> we decide to dynamic alloc sev_misc then in  sev_exit() we can use >> psp->sev_misc != NULL instead of psp->has_sev_ops. > > Yap, that sounds better than an explicit variable. > Sure, I will implement it and send you v5.2. thanks