From: David Woodhouse <dwmw2@infradead.org>
To: christophe barbe <christophe.barbe@inup.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: IRQ and sleep_on
Date: Mon, 05 Feb 2001 12:48:39 +0000 [thread overview]
Message-ID: <7066.981377319@redhat.com> (raw)
In-Reply-To: <20010205133837.A485@pc8.inup.com>
In-Reply-To: <20010205133837.A485@pc8.inup.com> <20010205131154.I31876@pc8.inup.com>
christophe.barbe@inup.com said:
> It seems to be ok. I've no more bad sleeps or more exactly rarely and
> that why I submit this to you. Is my way to do it correct ? I've
> joined at the end of this mail the modified function.
You can't restore flags in a different function to the one you saved them
in. It'll break.
You should probably be using the wait_event() macro instead, which does
something similar - actually it performs the check after setting up the wait
queue, rather than releasing the lock.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-02-05 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010205131154.I31876@pc8.inup.com>
2001-02-05 12:38 ` IRQ and sleep_on christophe barbe
2001-02-05 12:59 ` Manfred Spraul
2001-02-05 16:53 ` christophe barbe
2001-02-06 14:28 ` Anton Blanchard
2001-02-05 12:48 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7066.981377319@redhat.com \
--to=dwmw2@infradead.org \
--cc=christophe.barbe@inup.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox