From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com,
Mary Guillemard <mary.guillemard@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Mary Guillemard <mary.guillemard@collabora.com>
Subject: Re: [PATCH v3 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters
Date: Tue, 20 Aug 2024 12:01:42 +0200 [thread overview]
Message-ID: <7068759.18pcnM708K@diego> (raw)
In-Reply-To: <20240819080224.24914-2-mary.guillemard@collabora.com>
Am Montag, 19. August 2024, 10:02:22 CEST schrieb Mary Guillemard:
> Expose system timestamp and frequency supported by the GPU.
>
> Mali uses an external timer as GPU system time. On ARM, this is wired to
> the generic arch timer so we wire cntfrq_el0 as device frequency.
>
> This new uAPI will be used in Mesa to implement timestamp queries and
> VK_KHR_calibrated_timestamps.
>
> v2:
> - Rewrote to use GPU timestamp register
> - Add missing include for arch_timer_get_cntfrq
> - Rework commit message
>
> v3:
> - Move panfrost_cycle_counter_get and panfrost_cycle_counter_put to
> panfrost_ioctl_query_timestamp
> - Handle possible overflow in panfrost_timestamp_read
>
> Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com>
On a rk3588-tiger with matching MESA build and
"RUSTICL_ENABLE=panfrost clpeak"
Tested-by: Heiko Stuebner <heiko@sntech.de>
Without this change, clpeak fails with
clCreateCommandQueue (-35)
next prev parent reply other threads:[~2024-08-20 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 8:02 [PATCH v3 0/2] drm/panfrost: Wire cycle counters and timestamp info to userspace Mary Guillemard
2024-08-19 8:02 ` [PATCH v3 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters Mary Guillemard
2024-08-20 10:01 ` Heiko Stübner [this message]
2024-09-02 9:11 ` Steven Price
2024-08-19 8:02 ` [PATCH v3 2/2] drm/panfrost: Add cycle counter job requirement Mary Guillemard
2024-08-20 11:24 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7068759.18pcnM708K@diego \
--to=heiko@sntech.de \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mary.guillemard@collabora.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox