From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 217FC220687 for ; Sun, 15 Mar 2026 19:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773602162; cv=none; b=U+tr3Vt2cv1jY0IBgAuGk9cjEwJcQ+jaVoKm1gJ3MW8QjB5KZNipqY7PoZgO9g+jzQRmMUf6ao7WcOuEbxuX2kLpCfqhudr4SoRbLUjFBxbmnVyex2pYWB6k0+YMMX2radwu3v3dj+e1/JZvgb/wZXSeeQKbf0BXEnXm0ePk5wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773602162; c=relaxed/simple; bh=a6zCJ7W8/2j3GTCTCY6FAyHidVZVuKayQ1N0RO9KOEo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vk2UjxNsNmyNsQbIlwFE4xsYTqof4GbPBKMDWdLcpTvMnBuNyr5Wqx3sdSZvzCbrhtJzwpbRjVWQLYVo3jDw/UVirrTuNC5tZlwKnJ0p3yza4jWGeN4DreqXruBMpNXHKDt7wxeXD8fMZcChOR4XJ8hfD3RI5Gs7qGeY5UJCjjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DxvjKQs8; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxvjKQs8" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b9431300833so575500166b.0 for ; Sun, 15 Mar 2026 12:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773602159; x=1774206959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j24q+WEEaIIpTAaLp22q5B3jSJrQk0EvfwD9aUHG8bI=; b=DxvjKQs8kWy2u73OGxFvaR8tCE3IMk0ePE9vqxw+/7XaS9NXNB6JcuMm8TNqiGffmE +23cB11lX47Lw9mkCj433edZ698dowY9OD2NUX3y3hJ+NwzYB7w+CeOBQFWVDGXSCxur QLROn93dVOC8k6Dy7D+3zCpaatwExWf+h00rsMqKbMTeyqwNbB9twOOfKaXPCADsDCe7 enIEJFbjQMmK+iSymqPtkqn9BwxIMrpsNfzHQggWQ8NvIQlUOgIxw2v+qNiplciUbXYC AJNU6jfWtUFGTPbZdKcAdTD4CSdeLC52EEUXt6Ed+X/RBGgB1PkB2d+7DZl7WjXe7I0k R9Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773602159; x=1774206959; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j24q+WEEaIIpTAaLp22q5B3jSJrQk0EvfwD9aUHG8bI=; b=PIyFIxq4g8ZC7x+ti1zlGWHYuo+AkRXkKarhZTIn5oo9GJ7WwHU3cm3ry6y1Z2WAuf /EcnVHYq1h9NRTNsZVckZzb90nc73sRKTKGClWmYdXwTMPcOZpGFHLJxrt62RXX7YoLd 1yrDyPFLUtNLlqZDNbS0wuuKfE9E3DanPLYDg1Mh27kRdwASW/Xsbz65fg9VrtgZOJxl +j84askyvMskPTa7OlCa3Va9mDBePAL/Fw7SbHqgKH7tF329KVWfCQ1jfegfRWvMrndP DvxVkhX3vWScfvJu99lmQGSFF+TmU1ZRaMefmscDxGJQnfkv6kY7jB0xQU9eF1LWQJPn aeMg== X-Forwarded-Encrypted: i=1; AJvYcCWAScXjf1Ah2rFCwCl/m8t5/9Y0joldY/yFYHfzuOSmTaNc1mPX1mDQEMTQsgBVuZmbI83KsFh55v8BzDU=@vger.kernel.org X-Gm-Message-State: AOJu0YyvfJ1G1hA5XR6HXpbmQ9pztGttcnX1jubR4DTItrIW9jzLafAg R2+rkSZwwXwOXUyJc2D3Rhel29e0GogwngK7E1Ydmwh0/UXuqPJlb/UG X-Gm-Gg: ATEYQzwJ2XYtzzKe1QtaGSpxeHVI0mcZpWrlUa5j7zhT5r8t621rb0nsPk8e9WyJEqx Ci6gsG3Wd79FwFk3RwinXm3zivOlv5LCUxpJ0YcBW8q2M6bTSFoWXWmSNMi3V1GNqlmgTgxvMO9 jF/ZECrMB98p9S7hWS5tvdoEntCcfeH6sWhJn5z01NOrSpgivkbehaR82vxqkUHx0qWMj9Vh6lT ewpHd9+yfqle4wTqjHtlkiifm058j3EhiJJn2aBbQbut17ZLMLY0IJO2hnwTamBBe8bSUAL+hOU qAwAN7W40LyKxFKuwJxKINHEBQwCgDJk7KlLtjDslwcelkljJyr/Qe4APnJtuRDm2kskUJGjifm v8a++11UDmXUYKHhrcs3AGcACExHnFrRp6UYMfl7+P6s3W4D+oRQsIVn6Yz1LHFEJzWtshCzr5Z Il6gZZOrvCVbopazP8y+LsRsCIPA== X-Received: by 2002:a17:906:4a9a:b0:b97:f3:1231 with SMTP id a640c23a62f3a-b97653525a2mr439485666b.57.1773602158949; Sun, 15 Mar 2026 12:15:58 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb1d20sm421911166b.41.2026.03.15.12.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 12:15:58 -0700 (PDT) Message-ID: <706a349f-63e5-4f47-9f77-c84db1058f5e@gmail.com> Date: Sun, 15 Mar 2026 21:15:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] iio: light: vcnl4000: remove error messages for trigger and irq To: Jonathan Cameron Cc: David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> <20260314-vcnl4000-regulators-v3-5-3c4a48d30676@gmail.com> <20260315183127.59036e25@jic23-huawei> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <20260315183127.59036e25@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/15/26 8:31 PM, Jonathan Cameron wrote: > On Sat, 14 Mar 2026 18:06:34 +0200 > Erikas Bitovtas wrote: > >> The error code is available in the log after return. Remove duplicate >> error messages to reduce noise in dmesg. >> >> Signed-off-by: Erikas Bitovtas >> --- >> drivers/iio/light/vcnl4000.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c >> index e501db7249d7..c8bb1826b916 100644 >> --- a/drivers/iio/light/vcnl4000.c >> +++ b/drivers/iio/light/vcnl4000.c >> @@ -2041,11 +2041,8 @@ static int vcnl4000_probe(struct i2c_client *client) >> NULL, >> data->chip_spec->trig_buffer_func, >> data->chip_spec->buffer_setup_ops); >> - if (ret < 0) { >> - dev_err(&client->dev, >> - "unable to setup iio triggered buffer\n"); > > Is this one a duplicate? I don't recall us being particular verbose > in terms of error messages in iio_triggered_buffer_setup_ext() which is > where that ends up coming from. I think there is only one path > where it can return anything other than -ENOMEM and that one is a duplicate > registration check (so fair to not print). So perhaps all this patch > needs is a comment on what errors can surface from this call and why > it is therefore not worth printing anything. > I do not see anything being printed on iio_triggered_buffer_setup_ext(), so I guess this is not a duplicate. The function can return -EADDRINUSE if a buffer is already assigned, to prevent cleanup function being called on a buffer that wasn't allocated. I will add this print back if necessary in v4.