From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>,
hch@lst.de, song@kernel.org, chaitanya.kulkarni@wdc.com,
johannes.thumshirn@wdc.com, damien.lemoal@wdc.com
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one_chunk()
Date: Wed, 24 May 2023 09:03:17 -0600 [thread overview]
Message-ID: <7075bfd8-7c52-a778-5651-71ade3cd1f03@kernel.dk> (raw)
In-Reply-To: <20230524014118.3172781-1-yukuai1@huaweicloud.com>
On 5/23/23 7:41 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> 'end_sector' is compared to 'rdev->recovery_offset', which is offset to
> rdev, however, commit e82ed3a4fbb5 ("md/raid6: refactor
> raid5_read_one_chunk") changes the calculation of 'end_sector' to offset
> to the array. Fix this miscalculation.
>
> Fixes: e82ed3a4fbb5 ("md/raid6: refactor raid5_read_one_chunk")
This needs a stable tag as well, Fixes alone is not enough to guarantee
it ends up in stable.
Song, are you picking this up?
--
Jens Axboe
next prev parent reply other threads:[~2023-05-24 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 1:41 [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one_chunk() Yu Kuai
2023-05-24 6:04 ` Christoph Hellwig
2023-05-24 15:03 ` Jens Axboe [this message]
2023-05-24 17:21 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7075bfd8-7c52-a778-5651-71ade3cd1f03@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox