From: "Nuno Sá" <noname.nuno@gmail.com>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register
Date: Wed, 07 Feb 2024 10:08:38 +0100 [thread overview]
Message-ID: <70a4854e94cfd04b1a0ec9d3defe50ec56fc874f.camel@gmail.com> (raw)
In-Reply-To: <20240207033657.206171-2-demonsingur@gmail.com>
On Wed, 2024-02-07 at 05:36 +0200, Cosmin Tanislav wrote:
> As specified in the datasheet, the I2C FIFO data register is
> 0x18, not 0x42. 0x42 was used by mistake when adapting the
> ADXL372 driver.
>
> Fix this mistake.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> ---
This needs a Fixes: tag. With that:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> drivers/iio/accel/adxl367_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl367_i2c.c b/drivers/iio/accel/adxl367_i2c.c
> index b595fe94f3a3..62c74bdc0d77 100644
> --- a/drivers/iio/accel/adxl367_i2c.c
> +++ b/drivers/iio/accel/adxl367_i2c.c
> @@ -11,7 +11,7 @@
>
> #include "adxl367.h"
>
> -#define ADXL367_I2C_FIFO_DATA 0x42
> +#define ADXL367_I2C_FIFO_DATA 0x18
>
> struct adxl367_i2c_state {
> struct regmap *regmap;
next prev parent reply other threads:[~2024-02-07 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 3:36 [PATCH 1/2] iio: accel: adxl367: fix DEVID read after reset Cosmin Tanislav
2024-02-07 3:36 ` [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register Cosmin Tanislav
2024-02-07 9:08 ` Nuno Sá [this message]
2024-02-10 16:57 ` Jonathan Cameron
2024-02-25 14:33 ` Jonathan Cameron
2024-02-07 9:11 ` [PATCH 1/2] iio: accel: adxl367: fix DEVID read after reset Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70a4854e94cfd04b1a0ec9d3defe50ec56fc874f.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=demonsingur@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox