From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbcEEL4g (ORCPT ); Thu, 5 May 2016 07:56:36 -0400 Received: from mail-am1on0130.outbound.protection.outlook.com ([157.56.112.130]:56400 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753391AbcEEL4e (ORCPT ); Thu, 5 May 2016 07:56:34 -0400 Authentication-Results: virtuozzo.com; dkim=none (message not signed) header.d=none;virtuozzo.com; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCHv8 1/2] x86/vdso: add mremap hook to vm_special_mapping To: Ingo Molnar References: <1460388169-13340-1-git-send-email-dsafonov@virtuozzo.com> <1461584223-9418-1-git-send-email-dsafonov@virtuozzo.com> <20160505115240.GA29616@gmail.com> CC: Andy Lutomirski , Ingo Molnar , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "H. Peter Anvin" , X86 ML , Andrew Morton , "linux-mm@kvack.org" , Dmitry Safonov <0x7f454c46@gmail.com> From: Dmitry Safonov Message-ID: <70acdc9f-8980-0488-2d52-49a90c4b6a59@virtuozzo.com> Date: Thu, 5 May 2016 14:55:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160505115240.GA29616@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: HE1PR03CA0040.eurprd03.prod.outlook.com (10.163.170.178) To HE1PR0801MB1308.eurprd08.prod.outlook.com (10.167.247.150) X-MS-Office365-Filtering-Correlation-Id: 25403a9c-35ee-416a-aae8-08d374dc4c34 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;2:KH4V3zXlp5O14bqCOtOVU9k6vhWAOMWFHV8oYt1wo7GorIxRKB/UbCRi7onbtqAnBIKUeGYv4v6x9ngQBzlsyQXIhkzy9NljQwvkvHHSGMtxu3oQDlUS97C5kUHXHkHkuMVRRS/c0Cn7tMSTUQPY/MuYOp1LQ0UkSxKNv+gKObcMV3MJHJ2q4GHqDcYyTV6k;3:IG8QSAHekPTS6u5g+FmRdOprjI8LfWr0z8ZsjnUqW7f5bqKGUSwrrYmrm8kf9iRJjJs3UYVTo62cC45LFuKxFQ4BFosQyo0NFfFw4UcScW7XqXGxF1UK0eeDM1+k5lHG;25:2uxoXFXF0oy8ZqbSnlUSp0SeKP2S7NA4rzMnFgP3q6teEjRZtEClGLfbsPV70ehkyFpwH56mr65V9c5Ex8TpBd6yLA5YFakvT+XalIfr6yg874YQTGEj5hFOQJGlCtNDHUt/L1J3vFGwjRrjloG7W9ThMjSVm25QElxSzqUqp6SzkQ9RvTubpchYqG6YexamqunmQIcSGzX/k44dyWXGlGxNypxWP+3sNWqQmOdZIZerzKShaQahrQKjqSPsQ0FVR2STvazBRWcow1LrvF5v10Wgq/qSy6sVpzUnDI0xrbBFiG78gYpMRTkSIbjOvU5mtQZ9AfatuG1vQCWxFiwWJOtNz4WaQK9Vm+u1S8e5Sob0Yg3r7LpNqC/sTVnomsOgwmD8YjUtvJ/jZ6uRogmp75w7ZhVUmUOLtwQEeSXQvcb6lP5TPV4rzYFdw2noDasC X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1308; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521098)(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:HE1PR0801MB1308;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1308; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;4:CvtcXpg1tNNZUmxvdkErwnWbyXZLFYu2m59q0opgeoMaYf6WAH2bZLDouiFg+k+Rt4zve9Rskmyo/5W8M1pNOvTb2Y9ach6epI3lYZnUv6KtClFjK8QV8a15RvaG1sCGw0wlBPchgoaqgqgpGGcjGlfYq5suxjwbr83hO0UDKRHRa5KvawoMWqomVZ1tODBQepd6cEpSGJv9i8MHsg5tW4jZ/eMbw3OBkXBphfCzW2g5raaVX89/2Ae+1FG1L0slq28WQh2fONfGcJ4eVpDZWZKAIiFadSQ7+yKLTeo0u75H2hmKX9c3o7T9JFtNvCXuSPvLG4M92LZHXecWaSV073fr500JGoR4QBkpNNRcW2RYde7QORepzb8EckIEgs1J14WK1mlwFyVaet8dYppgRM+FsAtOSZBUD49fXpEhnmu4j6YIXREvu5s+VbgcE74mCzOrD12mNvNwPvTHiq6bbQ== X-Forefront-PRVS: 0933E9FD8D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(377454003)(24454002)(86362001)(5004730100002)(81166005)(92566002)(83506001)(50466002)(230700001)(77096005)(4326007)(189998001)(4001350100001)(76176999)(93886004)(54356999)(110136002)(2950100001)(50986999)(5008740100001)(3846002)(6116002)(66066001)(23746002)(586003)(65956001)(65806001)(31696002)(47776003)(31686004)(2906002)(36756003)(33646002)(64126003)(19580395003)(42186005)(19580405001)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1308;H:[10.30.26.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0801MB1308;23:h6FacStpnBfcVb/oqPdsmmiokXmdJX3zUct?= =?Windows-1252?Q?pgkuD1oQk09Mkix1xPcnuoljrXKY2LkiCXgu2nxgmG4JxdhZM+v2Tw9Z?= =?Windows-1252?Q?W+I1YsPLysOb430tz2rBOdWciOpkW0Jgk9xqOYumP13f6JzkczCDJ4yf?= =?Windows-1252?Q?xI7smB7Z+lGeh7vWqoPyfU7Xf5kIZCxdp4Qh3stJq9gpb1lT3jMv/dkz?= =?Windows-1252?Q?WY/X4V3zdrRPNEh91eHeGlcZOG9LngMKJw2ZRdZ8YfWBYWG1xFkKxqXf?= =?Windows-1252?Q?xvAizIfC8aN0Fr3rflsViHERo1F31kSWpPY+0Pq8QQpJK0bRUJMd7GDa?= =?Windows-1252?Q?tmkgD+lwVsaSSAomkW+5zVAw1L4dF6Oe+phtidxynsUvkCGebwzAXAqF?= =?Windows-1252?Q?dVlqxOJ1DvKjp+8IcZGPye4pWE8Up2yR9m4PgjfzLhwfF/l24bjwFZCj?= =?Windows-1252?Q?DzYuSI3nzeMl2wtl1yTMcnH2HR0046FfnjaC4hIZhS/XdShPqksA2Pdg?= =?Windows-1252?Q?9ir8kth8kAgpGtt9J3cNrj2a/AZZ4FG6KmW6kEnkGBvIP8+xoR27aiJX?= =?Windows-1252?Q?VUwPnfXhGRXPickHx+4ZdZf6S5c+gfb/sWTa7RHidqyNLSuoF8oefCF6?= =?Windows-1252?Q?Qg6M3COavVY2oZblz+DFryH9oB9o/mn5IB03C0dhSk7AdgrnTM2HQKZA?= =?Windows-1252?Q?xm0j4HLNQ6p/aWDGiAjHecopD2zsZUTAfur9K67s6sbo+u2JNIZcKwd4?= =?Windows-1252?Q?JmHEbV+Sp+vO5ltHQonAMYwX2vWdmKsIXuWVrs15zfy/GNlgATJrfSql?= =?Windows-1252?Q?hqtvtp/2KK9dneJckhr1gKL4fQ/0N87ZnlkKvrvZkO8llRQejafGknbQ?= =?Windows-1252?Q?FL5fWSp74K/QltzwuF4+u0y/8AoaWPwxY8KUx6a1VSAjvehsepj/fpq4?= =?Windows-1252?Q?7g6joXkPcgGQATHaZUUxrCCWreP4I4Pd0h4lnLBcChP65XuV/Tg11nT2?= =?Windows-1252?Q?u8+m7wm8jcoWmouoFaR3wc809qpET7V683WJFHRvOjYmzKY1XA0G5Rq0?= =?Windows-1252?Q?J1cczunzXyob35CajrS14+jjsydpETAJ+oRM4iw0vP0I73BtfJjPl9MM?= =?Windows-1252?Q?5GdU4nG7gE8D4cLwybmpv1G0UGyNps9YfY1b7uqJsYxMRWZ17ym+Nc4t?= =?Windows-1252?Q?d5dSxajFbcQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;5:YQR5fcO0qRMFShlpHqy2haOXhaL2+8Xb8HgVCD0Z2ERYPFg5T+mKoErZzJMj8Sr22EGz48RvZv4nwv4IrQvInDbL3uiSNS524PteGWKcxzWi6PuaQmlPle4emlqA85hgtjiwRmc1GRH3z0Yj9UrDOw==;24:NvQfMZARKofBeYED/u2r4mdMId157OJcvZnvBOMg4KHU7QO8wawJ0DaArKiXK4GVMHSd27g+J01DyThAiX/3qEab3btiV493S+GuG4o1CAg=;7:lsFY3Xh2AGNBvCmAFVbuWMraij/gUm61XbK7VEIwowPmdAB3LZcpjoSvQu8BFb2JVe+wgsLTXO0SmV/XaPT97NIfZ9L+Bug6tOfsKw7GhsVdNtVnnZrinQQmI6240I9zMxDKCDBoACsljGp2TWiHAlTgES2wAZm5h0ywQbJl+eL2SS1vtg7laIzocJO3H085;20:MNOiwt3DAZoJjhjIVz5O5Im51Y1axUxbKJK5oaG3s3bCnnzjLZIX2aJhYjct0f6M1fXgizZPuSGiHvb1y8AzVoWMogrtzLnxa6sH/SY4OoRsi2R561NVdeyAjydJc0lXA568ei7J98Y/AdZYm04VPMmJzX0AeslleuytFa6ujBE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2016 11:56:29.8424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1308 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2016 02:52 PM, Ingo Molnar wrote: > > * Dmitry Safonov wrote: > >> On 04/26/2016 12:38 AM, Andy Lutomirski wrote: >>> On Mon, Apr 25, 2016 at 4:37 AM, Dmitry Safonov wrote: >>>> Add possibility for userspace 32-bit applications to move >>>> vdso mapping. Previously, when userspace app called >>>> mremap for vdso, in return path it would land on previous >>>> address of vdso page, resulting in segmentation violation. >>>> Now it lands fine and returns to userspace with remapped vdso. >>>> This will also fix context.vdso pointer for 64-bit, which does not >>>> affect the user of vdso after mremap by now, but this may change. >>>> >>>> As suggested by Andy, return EINVAL for mremap that splits vdso image. >>>> >>>> Renamed and moved text_mapping structure declaration inside >>>> map_vdso, as it used only there and now it complement >>>> vvar_mapping variable. >>>> >>>> There is still problem for remapping vdso in glibc applications: >>>> linker relocates addresses for syscalls on vdso page, so >>>> you need to relink with the new addresses. Or the next syscall >>>> through glibc may fail: >>>> Program received signal SIGSEGV, Segmentation fault. >>>> #0 0xf7fd9b80 in __kernel_vsyscall () >>>> #1 0xf7ec8238 in _exit () from /usr/lib32/libc.so.6 >>> Acked-by: Andy Lutomirski >>> >>> Ingo, can you apply this? >> >> Hm, so I'm not sure - should I resend those two? >> Or just ping? > > Please send a clean series with updated Acked-by's, etc. Thanks, Ingo, will do. Sorry for html in the last email - mail agent got an update and I overlooked html composing become turned on. -- Regards, Dmitry Safonov