From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933657AbcIXORX (ORCPT ); Sat, 24 Sep 2016 10:17:23 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34672 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758253AbcIXORU (ORCPT ); Sat, 24 Sep 2016 10:17:20 -0400 Subject: Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up To: Baoyou Xie , isdn@linux-pingi.de References: <1474694662-7527-1-git-send-email-baoyou.xie@linaro.org> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Sergei Shtylyov Message-ID: <70bf808d-bc5f-ce91-307e-99ec735c70df@cogentembedded.com> Date: Sat, 24 Sep 2016 17:17:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474694662-7527-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] > > In fact, this function is declared in > drivers/isdn/hisax/elsa_ser.c, but should be > declard in a header file, thus can be recognized in other file. Declared. > So this patch moves the declaration into drivers/isdn/hisax/hscx.h. > > Signed-off-by: Baoyou Xie [...] MBR, Sergei