From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags
Date: Mon, 5 Feb 2024 13:52:57 -0600 [thread overview]
Message-ID: <70c54f80-9fb1-4789-b371-eead597423f5@linux.intel.com> (raw)
In-Reply-To: <20240205182436.1843447-1-colin.i.king@gmail.com>
Thanks for the clean-up!
> The variable link_flags is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/soundwire/intel_auxdevice.c:624:2: warning: Value stored
> to 'link_flags' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/soundwire/intel_auxdevice.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
> index 93698532deac..95125cc2fc59 100644
> --- a/drivers/soundwire/intel_auxdevice.c
> +++ b/drivers/soundwire/intel_auxdevice.c
> @@ -621,8 +621,6 @@ static int __maybe_unused intel_resume(struct device *dev)
> return 0;
> }
>
> - link_flags = md_flags >> (bus->link_id * 8);
> -
this redundant line is 3+ years old now, added in a2d9c161db24
("soundwire: intel: pm_runtime idle scheduling")
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> if (pm_runtime_suspended(dev)) {
> dev_dbg(dev, "pm_runtime status was suspended, forcing active\n");
>
next prev parent reply other threads:[~2024-02-05 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 18:24 [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags Colin Ian King
2024-02-05 19:52 ` Pierre-Louis Bossart [this message]
2024-02-07 8:52 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c54f80-9fb1-4789-b371-eead597423f5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox