* [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags
@ 2024-02-05 18:24 Colin Ian King
2024-02-05 19:52 ` Pierre-Louis Bossart
2024-02-07 8:52 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-02-05 18:24 UTC (permalink / raw)
To: Vinod Koul, Bard Liao, Pierre-Louis Bossart, Sanyog Kale,
alsa-devel
Cc: kernel-janitors, linux-kernel
The variable link_flags is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.
Cleans up clang scan build warning:
drivers/soundwire/intel_auxdevice.c:624:2: warning: Value stored
to 'link_flags' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/soundwire/intel_auxdevice.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
index 93698532deac..95125cc2fc59 100644
--- a/drivers/soundwire/intel_auxdevice.c
+++ b/drivers/soundwire/intel_auxdevice.c
@@ -621,8 +621,6 @@ static int __maybe_unused intel_resume(struct device *dev)
return 0;
}
- link_flags = md_flags >> (bus->link_id * 8);
-
if (pm_runtime_suspended(dev)) {
dev_dbg(dev, "pm_runtime status was suspended, forcing active\n");
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags
2024-02-05 18:24 [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags Colin Ian King
@ 2024-02-05 19:52 ` Pierre-Louis Bossart
2024-02-07 8:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2024-02-05 19:52 UTC (permalink / raw)
To: Colin Ian King, Vinod Koul, Bard Liao, Sanyog Kale, alsa-devel
Cc: kernel-janitors, linux-kernel
Thanks for the clean-up!
> The variable link_flags is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/soundwire/intel_auxdevice.c:624:2: warning: Value stored
> to 'link_flags' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/soundwire/intel_auxdevice.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
> index 93698532deac..95125cc2fc59 100644
> --- a/drivers/soundwire/intel_auxdevice.c
> +++ b/drivers/soundwire/intel_auxdevice.c
> @@ -621,8 +621,6 @@ static int __maybe_unused intel_resume(struct device *dev)
> return 0;
> }
>
> - link_flags = md_flags >> (bus->link_id * 8);
> -
this redundant line is 3+ years old now, added in a2d9c161db24
("soundwire: intel: pm_runtime idle scheduling")
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> if (pm_runtime_suspended(dev)) {
> dev_dbg(dev, "pm_runtime status was suspended, forcing active\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags
2024-02-05 18:24 [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags Colin Ian King
2024-02-05 19:52 ` Pierre-Louis Bossart
@ 2024-02-07 8:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-02-07 8:52 UTC (permalink / raw)
To: Bard Liao, Pierre-Louis Bossart, Sanyog Kale, alsa-devel,
Colin Ian King
Cc: kernel-janitors, linux-kernel
On Mon, 05 Feb 2024 18:24:36 +0000, Colin Ian King wrote:
> The variable link_flags is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/soundwire/intel_auxdevice.c:624:2: warning: Value stored
> to 'link_flags' is never read [deadcode.DeadStores]
>
> [...]
Applied, thanks!
[1/1] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags
commit: 9282cfa2eb080e3bbb95f488af35618b614cdf76
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-07 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 18:24 [PATCH][next] soundwire: intel_auxdevice: remove redundant assignment to variable link_flags Colin Ian King
2024-02-05 19:52 ` Pierre-Louis Bossart
2024-02-07 8:52 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox