From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936828AbdLSMn1 (ORCPT ); Tue, 19 Dec 2017 07:43:27 -0500 Received: from mga11.intel.com ([192.55.52.93]:57820 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934444AbdLSMn0 (ORCPT ); Tue, 19 Dec 2017 07:43:26 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="160081018" Subject: Re: [PATCH 2/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies To: Andy Shevchenko , alsa-devel@alsa-devel.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org References: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> <20171215004451.30800-3-pierre-louis.bossart@linux.intel.com> <1513335523.7000.95.camel@linux.intel.com> <5d02951a-63d3-eb33-142e-46f16612626b@linux.intel.com> <1513680571.7000.169.camel@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <70c6567c-5ba2-1be8-4203-aee6df3cea13@linux.intel.com> Date: Tue, 19 Dec 2017 06:43:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513680571.7000.169.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> - depends on SND_DMA_SGBUF >>>> + depends on SND_DMA_SGBUF && ACPI >>>> depends on DMADEVICES >>> Perhaps >>> >>> depends on DMADEVICES && ACPI >>> >>> to be in align with below? >>> >>>> config SND_SOC_INTEL_BAYTRAIL >>>> tristate "Intel ASoC SST driver for Baytrail (legacy)" >>>> - depends on DMADEVICES >>>> + depends on DMADEVICES && ACPI >> I must admit I don't know why it's different, I just cleaned-up what >> I >> could. > What I'm talking about is to use same pattern, so, in the first case > > depends on SND_DMA_SGBUF > depends on DMADEVICES && ACPI ah ok, thanks for the precision. > > The question WRT SGBUF is indeed another one to Liam or whoever knows > better. > >> Maybe Liam can comment since I believe he contributed to both >> Haswell and the initial Baytrail driver?