From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011055.outbound.protection.outlook.com [52.101.62.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E20A342536 for ; Fri, 14 Nov 2025 20:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763152026; cv=fail; b=KkQ5chShNQKVsyZA+q3+k05dBOtsPaByJST9F/GJMVccW6Je2CINIJ8HGtHx0c7H2W2mRglKJoBWQeO4a8kiI96/Zc+P/GnOOcmbQ+7p1zSUZzE8azAKhw2hFCbwHxsK54DbHpdT2Tj0xAJBjgs+6qmDZoktbNboIUuG9sb/hbk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763152026; c=relaxed/simple; bh=A1w0OKDXHRnq5C5wkHxiI03RYnC3DEQQft9aHITnYoE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=GPujo9YSlZGs/uHrRHZtNnV2Y2LK9zDhuds0/kCyXfB2lNbBa/rAn3068BBA42YoDIRbEq3S7vWhSFBx8f3PDZXwydhv3x3xKtvlajNzB2o8eY6Y6NqNvhKBc9vsINGTnVxLL7G/9UCQ0GIKeRQjE5gFQTzDOmEmGag9WHVq55I= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AmBaor1h; arc=fail smtp.client-ip=52.101.62.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AmBaor1h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=btBvggtkGCo3xUlrP8M2zo/aIAcc7+BXJVku/rDBJz6S/aw2v5t6KLttpGd4qltoTj1DmnNdzjpLvq7DO6+Rxy12hAauUG+GLzBcIw8q2mwDcTFL6C8im9/utEn3weJD4cp1+fgK2h8+Pop/xsUk850T9Oqa0OIAv2otJPOoqdg7tIC2Ewz5ayCgkAk9MjGqGxee1QsObcNhAOCkTWuT9gH+rT8YSIWFC+C0fTEEyQY7ezNEwF7/m0crWBrcaBbbNnLmmtk0MTr5ZJ5wgAdiXtIJ7fPy/pvhFyM2gO90r7OjtlBLkaA+v10AMdxjDBtve/cPt/aamxjufyY0/BIUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fnaldgOVI8hU+CJuVRIUzHpB34MrOKTm3Rrlni37Mr8=; b=ekkeN8QhD/hLNUX7neeLMUaVNK47sn5RG9XYPJSBeCLvGP4txaoEMo0VL9Ryg8e8rEx/Raf331Fq9jNR4P/RCsZJOGL3Db5Mp3jwmC4aj/Nuk9FYb7SjBfPqhLQDJnJJjViCAzWY1Pjar6uOffuL1rAepnoAHsW36/Fos0KmGr6JWuR+4wGtA2x5HYBnlYZvUloHaecVBTlHN59gpRH5JFvDTcl2iRL0Ho/Cpcum9/qVil9cKfdkKpx3sssj80sdNGQEHLzGhIAVn/D0a+5nyAFZLpo17mxHI5AD81V1J5Doy+u1zeYG38d36jSi2F4zdExP6SFIIE5s9ZlrMqoz8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fnaldgOVI8hU+CJuVRIUzHpB34MrOKTm3Rrlni37Mr8=; b=AmBaor1hsJIa0y8iG/JR9Nfm+a74vRvlGNNlmOlaEBQUqooh2udGszPHpSlGqo4G5rfHM5dWsKaQS4FEraOqFxosiy6uJeg/pHCGEcHsbmF9TLsYEkRW7bfc7Rb0OyXN+77nTi8Ve7h9ySNdSPD9eTuYjbobkjWivhwj94hA7SFgSDGxEhIulp+IsASJkH2w6CttFX5O5tYLo0Dbgh13IgdyF/eMObKbz4gW3upVA7OOUk3KVKu5FWE+TnXpQGXbyyjIlytlSqCg/J6U8rVAVlOowyFGKFfSYY/isFqv3x9IeXHQj9w+a4fKqEmSYTWQN6gyLO7IJXxB3ozwYCbPtw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by CH3PR12MB9249.namprd12.prod.outlook.com (2603:10b6:610:1bc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.17; Fri, 14 Nov 2025 20:27:02 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb%7]) with mapi id 15.20.9320.013; Fri, 14 Nov 2025 20:27:02 +0000 Message-ID: <70d7ef58-8556-4aa4-86c8-b7ed79505471@nvidia.com> Date: Fri, 14 Nov 2025 12:26:58 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Fix the source file annotation information for the "FOLL_WRITE" macro copied. To: peng8420.li@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca, peterx@redhat.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com, "David Hildenbrand (Red Hat)" References: <20251114161127.193707-1-peng8420.li@gmail.com> <20251114161127.193707-2-peng8420.li@gmail.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20251114161127.193707-2-peng8420.li@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR03CA0013.namprd03.prod.outlook.com (2603:10b6:a02:a8::26) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|CH3PR12MB9249:EE_ X-MS-Office365-Filtering-Correlation-Id: b567ec48-ce4e-4dee-77bc-08de23bc2b41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WGNYUFk1MjZ4ZVM0c3QyMzFSYzg2OEkxa0x1clQzWDN0bmVMSUExa1NhZTJD?= =?utf-8?B?THlDeGx6aXFid0N5V2lMaXFFZDZSRXBZSlhjT0g1eEt6WlFYZTk4Tk9GeVBH?= =?utf-8?B?QU5DZlVPSVdDQlA1K1VDUkJ2bUN5RWI1UUVHWkV0MUZCMi9HT1lxSFBLSzNa?= =?utf-8?B?YkdLZ3VZcjFvaEtjRnVVWkMxSzJKTDlMQ1BQNWVkT0NBWHErR1MremxxUHNs?= =?utf-8?B?b2lsNzRycVlVMlJ3anlxOEVnN0ZDMVJIRlNBNjBzMEh4ZUt4OWZaalVVYTNq?= =?utf-8?B?OEFYa1p0cVY2ZythSU9PVUo5QzV2SnpQdG9kYWdRQUw2cjBzMC9sbG5HNWNH?= =?utf-8?B?WGNZMEJoWDVrWVZST3FkZUwwdXJSeERJRjBZdHZRUFVONk9relBGc3gxTkNT?= =?utf-8?B?c0cwb3lnNzVkNE55c0NlVG9tbituVWk4WUg3WnA5MldNcU1kR1B3Qjl5Tzd1?= =?utf-8?B?TlgyWTl2NGhJTnpZMWVxa2NJL0JENG5neFJuNGtrak1XZEttNU9MYTUyS2t0?= =?utf-8?B?N1FNOC92N3dnUTVFbzhiNkZaQSsxd0t4UjBWUUplT3RXS25TVXhLQU9wVmIy?= =?utf-8?B?SWpWVURINytlVkcwQ2dwa1Y2VXVvbUljU1ZJaHQ5WllEa3JYV0FGdWgwWVNF?= =?utf-8?B?ZllLM2xvd2N5K3lFV3NoMmVvM2M4VmZyN1NRMllBU1hnbUhaRCtERXNpRXp5?= =?utf-8?B?ZjErWkxnaUdlUUFvbDJ5NTNtMjU4QytLaXNtUVhmbENSY2t4MHhYeWdGc1p6?= =?utf-8?B?L2Rxc0JiMW1Kb0Z5MUNRcXRSczJ5b3dzVGlpU3RZeGV6OVg0anhNQkxjRkNm?= =?utf-8?B?UkNUdWFWa1NFVWxNRFB0REMxbGdwTzBnR0VtSHI0RnJ5REhDNGRtZHBZME0z?= =?utf-8?B?ejZrbTF0QTBzdW1MdWpnT3MwY0RIUVY1UXJUZ0hBNVpQOXFLQU93RDJ0SzZS?= =?utf-8?B?WlFJS3ZZOEZ1eVo4QjRiT0o1RHgwNFlnMGJWK3VOZTI4aHo5OEVRMTlUU2JF?= =?utf-8?B?T3FTTmRMcktBWG9Qc1hJR0dSWU1vNXBkM01tOTU2b3hFYzd2VDE2OENHQWcx?= =?utf-8?B?TjA4cU9XL01TREhkNUJBbG5jMjhXVU84RlNnN1RINjR5Z1NNYm1QeWljaW1O?= =?utf-8?B?bUF2aWpTb09rMmxYMFZBenI5NktFM3NpODE0STZ3bkRjeFlCTE8rdjRYeVBK?= =?utf-8?B?RmFFZGp6ekcxaVJlcHE1Z2NaSzlGZ3d6TFpaUHVta0dZUytwZm52bi9DZmRx?= =?utf-8?B?RXMzMWpZMW1RNUpKVzI4elViOWkrNjVDMi82NW5mZlNIRGJHMUwvWWRnZGgr?= =?utf-8?B?THA2V3M0RE9yYVVuMHJhcXp5akRTb3RoejR6bVFyNGJ1SS94dFNGbUMySDJL?= =?utf-8?B?U3VBNWlpbjVLTHBLWkdtU2ppVzZ5WXA4bUlpTDNCOHcxTmwwcVdndTlEc2lv?= =?utf-8?B?NGh6MmFmN1lISjRkTjRDNC8wWUxnejN6eHZNdkE0NW9sQVFRU0Zmb0Fodnhp?= =?utf-8?B?cTlwZVpnLyt1bDFySWhKU1FCMkh0UzVNeWoxSU15Skx5NmFMakpQWHV1WmlD?= =?utf-8?B?RXZxWjVhdFJRV0pMa093Mi9LWTF1TG9rZTh6d0tXcG9pOEZHbklUeldEam1o?= =?utf-8?B?d3JjVzFoWFBCeVYwM0w5RzBjS0R5R0xkUi9OQVNCSDhuY2Yzb3ZOWlFXNHFH?= =?utf-8?B?aGhtLzlJcnE1UG9TKzQzM3hIYUh2ejcxV1FJeVRNUVZPUFVZemkxWmUxOC9s?= =?utf-8?B?Ym5GUWdzb0k4TzVUaGUyRXF5cDFQN2YrdCtFUGhHL2ZRYVlsd3Qrci85enJ0?= =?utf-8?B?NW5aMWFONkZ1dWhMTTh2L3NjUGVLTHdGWk1yZ2pDUGw3UXh3aGw0VnBaWEVO?= =?utf-8?B?YXNLdGE3Q20vYklIWVFRSnNKOFBkMmJJTWt0WW9IWU9LUEJ3ZDcyUWZyMjBm?= =?utf-8?Q?oteX8Dm+BfiuAQ2zKzptR1OSluQz8Gal?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjJUY1VkV2IyOFB5VDdJOVZLbCs3dVNoTkhPT0FWVHAvNjhwWjhTSXdKZ1RB?= =?utf-8?B?R2lLNW1sWHpHREZuNFpvcms1TDBmZ25YYnc5S2xRNVY5STNobFUyZmIyUEtC?= =?utf-8?B?SkhKNStsZ2FhMzNXQmxqdW1yUFJ5Mko3Kzd1NEp6azFodWJPcnNmSXIxdW5X?= =?utf-8?B?elFaanJLNFVFbm5xcTlYWE5nRmV3UE1XWGVIZXNNREFKVGZSTTZpTlBuQXlP?= =?utf-8?B?aWQ1algrV29kaWhZVnFLTzNDN3ZDbzJ1SG9WY0N4R3YvRHoydkpFTTY1bzRL?= =?utf-8?B?RXhLUjlnTzNIU3ozOHN2SzE5QVpaZVlJaEJiSERKOEZqK0VxbGFScU1tN0ZD?= =?utf-8?B?K0FuTzVIZy9qUDhXbFRzWDlOWng1NXFzNVBFZDJwS2lkbXBLdk92Z1NncTJX?= =?utf-8?B?TkVxY2o5ekhMcUtnVTA3UFBZaHRQa2laSHV2Y1gxSlFpQ2tkWDlRcGljcGdY?= =?utf-8?B?clZWZjBwcEhCM2JLQzZkOFhVN1lac3BuSWJIaXM1OG9pMXM2TFZ0NThFUGsx?= =?utf-8?B?NGpaRVQwUjRPNm9qNVpmR0JKNWdpUWI4MGdjMmJYWWE5dWVBT1MzK1hjb1FC?= =?utf-8?B?NzUvVjE5UEdEZE4rQmh6TUd1eGxOWGUrdGlLcTlXb3hqbURLTnJIZFlmdlpn?= =?utf-8?B?N01NbGNGbXRENGdFdFRyck5Sd2xnUG9UTHcxNjNZcDViREJpNTlLcXRYQ1Ra?= =?utf-8?B?VExpY09selc4V0JZOS9CeC83b0NMblBZWFpveXo5VnFCRXhsQWR2UEU2SGIy?= =?utf-8?B?eXI0Y2dsNlJ2UDZWSXJjbmVMWk5GbWxQRzErUzhaZ1NTVkM1MTFVMlZZWFg4?= =?utf-8?B?WGJrUDZiRjNvdkl2TVpUNlZtbldjbStVUnV4SVpxUmpkZmZzRnVPM083RFpD?= =?utf-8?B?WVRFMmNRSXVramFUb3RnNnI5WW1vWUFUSzJ0OFNLOUZIVmcvYXFKMm9OOVZM?= =?utf-8?B?WTNLWkVqTGRBdDQxOW9icnE4cm5HMXdEQkl2SktvWnZmanl5S2NQczU5Y2ww?= =?utf-8?B?Y0tkSCtnYkxJRUdsWmNXTHpEa0JmVHNZRWxwV2crWnZ0WGIwcHZlbVVERTA1?= =?utf-8?B?S1plZW8wYlJOcHh0eEpwSm52UStCQXVXTTFHREtGSDBGMTFZcHdTQzUrOFRJ?= =?utf-8?B?SklqMm54U0l3TmUzY09HYURsSmdMWmkvUUYvSWl3dmdsQ2p6QlV1SmYwUkI0?= =?utf-8?B?SzB6WFV1dFlXZWppYllHdmNKemRuZ0ZWYnJab21SdnB3WDVscUJEdGxMK2VN?= =?utf-8?B?cStpRHZkelV4RGVWK1IwdlNIb1Bkbm5KMFkvaTY5ekh5TlE4QVdsYXpIWVpX?= =?utf-8?B?am0vRXZkb1FwVjljUzdXYVYyc3lqMkhhUXpCZkVnTUZyNk4zZFNRR0doS0lS?= =?utf-8?B?MmxwY20zeGVEVFFRL3ZaQzVXenhQbnRDanl5VHc0c0diN09WRjZ3bmZkSjFK?= =?utf-8?B?RjNuYzlxbVJHSml2WEFYckZlRDR3ZVpndElRRVB1b3NwUW96aEdRQzVBbWlt?= =?utf-8?B?ZXdBVzFKeUY5a2haTjhrVy9rcVkrSXFMTmxocjdOYWdhSENCQ3JYMDhvTDIy?= =?utf-8?B?SnhNRVhyRzlwMWZQR3RkL0dMSnJGcmE4K1pIM0xWamZVV1BVVkNDQXlGeTBp?= =?utf-8?B?Z1p6RSt2T2ErYXdvWDRtdXVJbFpYbkI2VEdKTkpldUkwbEt1SnZFVTlWQWVB?= =?utf-8?B?Sk52M0pjVWdpeUNLMktJV0R3VTVhV3pxeVBQVHdXOGNQNEdCb0RuTmhQNUlh?= =?utf-8?B?WEdROEN3REE3OEErK3ZiSzdhTVN4OTBZVE5mekZyQlpsZHFHSEE4azVaTkJX?= =?utf-8?B?eDhwQzN0cjlFcld5YW5xK1hzdW1GMU51cktaWDdxdytodVVjMU41c1laRGcy?= =?utf-8?B?UlVZT2FVY1hsT0ZSdFgrNU1RbzVHL2I1WG9HM2l5L2lSUncyanZtK0IweVlJ?= =?utf-8?B?S3Nrc1Zhb1ZPRUVOOGZVSFNLWWRYZy9TK0I4NmlKdEdaOGlLMDV3VUk5UVVC?= =?utf-8?B?ZzhEc1RVTW16RjF4VExSN1MvK2cvOGNSU0VCcDd0cW1VVTdnZ215cnhQYVVB?= =?utf-8?B?S3BWR2dKZUVGZU1rc3ljUkkwa245dFV2YUh2Z3k2ZGdkMmlCNG9idHhvS2pP?= =?utf-8?Q?4WKZUFJJoMzyFFDn1S9cGIYWq?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b567ec48-ce4e-4dee-77bc-08de23bc2b41 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2025 20:27:02.2541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FtaGWpJX93XuOzrAXMFUktLKu6qSprBgqrol/G4bK2bDFDJ1G9F7Zz/ID57XYkb5p3faDD43EWAOLFalX0Lzog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9249 On 11/14/25 8:11 AM, peng8420.li@gmail.com wrote: > From: "peng8420.li" Please see my reply to patch 1/1, about the real name, and the From: item too. > > The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it. "FOLL_WRITE" Also, please wrap to 72 columns. > > Suggested-by: "David Hildenbrand (Red Hat)" > Signed-off-by: peng8420.li > --- > tools/testing/selftests/mm/gup_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c > index 75f7134d529d..40c1538a17b4 100644 > --- a/tools/testing/selftests/mm/gup_test.c > +++ b/tools/testing/selftests/mm/gup_test.c > @@ -17,7 +17,7 @@ > > #define MB (1UL << 20) > > -/* Just the flags we need, copied from mm.h: */ > +/* Just the flags we need, copied from the kernel internals. */ > #define FOLL_WRITE 0x01 /* check pte is writable */ > > #define GUP_TEST_FILE "/sys/kernel/debug/gup_test" With the commit log fixed up, please feel free to add: Reviewed-by: John Hubbard thanks, -- John Hubbard