From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbdA3JKn (ORCPT ); Mon, 30 Jan 2017 04:10:43 -0500 Received: from mga01.intel.com ([192.55.52.88]:42154 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794AbdA3JJ3 (ORCPT ); Mon, 30 Jan 2017 04:09:29 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="37224911" Subject: Re: [PATCHv1 1/2] mmc: sdhci-msm: Remove platform_execute_tuning from sdhci_msm_ops To: Ritesh Harjani , ulf.hansson@linaro.org References: <1485247827-12898-1-git-send-email-riteshh@codeaurora.org> <1485247827-12898-2-git-send-email-riteshh@codeaurora.org> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, asutoshd@codeaurora.org, stummala@codeaurora.org, venkatg@codeaurora.org, pramod.gurav@linaro.org, jeremymc@redhat.com, git@kchr.de From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <70dce604-ffb9-eefb-dbd8-b287aef5ff0c@intel.com> Date: Mon, 30 Jan 2017 11:04:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1485247827-12898-2-git-send-email-riteshh@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/17 10:50, Ritesh Harjani wrote: > platform_execute_tuning should not really exist as it does not > do anything useful. > > So remove this ops and directly plug sdhci_msm_execute_tuning > with mmc_host_ops. > > Also in case of HS400 tuning clear SDHCI_HS400_TUNING flag once > HS400 related mode selection is done. > > Signed-off-by: Ritesh Harjani Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-msm.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index f958697..b3e8f44 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -827,12 +827,12 @@ static int sdhci_msm_hs400_dll_calibration(struct sdhci_host *host) > return ret; > } > > -static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode) > +static int sdhci_msm_execute_tuning(struct mmc_host *mmc, u32 opcode) > { > + struct sdhci_host *host = mmc_priv(mmc); > int tuning_seq_cnt = 3; > u8 phase, tuned_phases[16], tuned_phase_cnt = 0; > int rc; > - struct mmc_host *mmc = host->mmc; > struct mmc_ios ios = host->mmc->ios; > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); > @@ -855,6 +855,7 @@ static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode) > if (host->flags & SDHCI_HS400_TUNING) { > sdhci_msm_hc_select_mode(host); > msm_set_clock_rate_for_bus_mode(host, ios.clock); > + host->flags &= ~SDHCI_HS400_TUNING; > } > > retry: > @@ -1119,7 +1120,6 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) > MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match); > > static const struct sdhci_ops sdhci_msm_ops = { > - .platform_execute_tuning = sdhci_msm_execute_tuning, > .reset = sdhci_reset, > .set_clock = sdhci_msm_set_clock, > .get_min_clock = sdhci_msm_get_min_clock, > @@ -1294,6 +1294,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > MSM_MMC_AUTOSUSPEND_DELAY_MS); > pm_runtime_use_autosuspend(&pdev->dev); > > + host->mmc_host_ops.execute_tuning = sdhci_msm_execute_tuning; > ret = sdhci_add_host(host); > if (ret) > goto pm_runtime_disable; >