From: Minda Chen <minda.chen@starfivetech.com>
To: Rob Herring <robh@kernel.org>
Cc: Pawel Laszczak <pawell@cadence.com>,
Vinod Koul <vkoul@kernel.org>,
"Albert Ou" <aou@eecs.berkeley.edu>,
Kishon Vijay Abraham I <kishon@kernel.org>,
"Peter Chen" <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
<devicetree@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-phy@lists.infradead.org>,
"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
<linux-usb@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Conor Dooley <conor@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: Add StarFive JH7110 USB dt-binding
Date: Thu, 9 Mar 2023 11:45:29 +0800 [thread overview]
Message-ID: <70e0d1b2-349a-079c-646f-394edf080fbe@starfivetech.com> (raw)
In-Reply-To: <167828360080.2613078.14112010625330944896.robh@kernel.org>
On 2023/3/8 22:06, Rob Herring wrote:
>
> On Wed, 08 Mar 2023 16:27:58 +0800, Minda Chen wrote:
>> Add StarFive JH7110 SoC USB 3.0 phy dt-binding.
>> USB controller is cadence USB 3.0 IP.
>>
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> ---
>> .../bindings/phy/starfive,jh7110-usb-phy.yaml | 158 ++++++++++++++++++
>> 1 file changed, 158 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.example.dtb: usb@10100000: phy-names:1: 'anyOf' conditional failed, one must be fixed:
> 'cdns3,usb2-phy' was expected
> 'cdns3,usb3-phy' was expected
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.example.dtb: usb@10100000: 'phys' is a dependency of 'phy-names'
> From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/phy/phy-consumer.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230308082800.3008-2-minda.chen@starfivetech.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
I am sorry about this, I just run dtbs_check, not dt_binding_check. Next version I will fix it.
next prev parent reply other threads:[~2023-03-09 3:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:27 [PATCH v2 0/3] Add JH7110 USB driver support Minda Chen
2023-03-08 8:27 ` [PATCH v2 1/3] dt-bindings: phy: Add StarFive JH7110 USB dt-binding Minda Chen
2023-03-08 14:06 ` Rob Herring
2023-03-09 3:45 ` Minda Chen [this message]
2023-03-08 18:12 ` Rob Herring
2023-03-09 4:10 ` Minda Chen
2023-03-09 10:07 ` Krzysztof Kozlowski
2023-03-10 8:01 ` Minda Chen
2023-03-08 8:27 ` [PATCH v2 2/3] usb: cdns3: add StarFive JH7110 USB glue layer Minda Chen
2023-03-08 8:28 ` [PATCH v2 3/3] dts: usb: add StarFive JH7110 USB dts configuration Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e0d1b2-349a-079c-646f-394edf080fbe@starfivetech.com \
--to=minda.chen@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox