From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF638C4741F for ; Fri, 25 Sep 2020 09:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84C3B206B5 for ; Fri, 25 Sep 2020 09:13:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="ZADbOy3Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgIYJN1 (ORCPT ); Fri, 25 Sep 2020 05:13:27 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:32434 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727692AbgIYJNZ (ORCPT ); Fri, 25 Sep 2020 05:13:25 -0400 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 08P9CxNk015637; Fri, 25 Sep 2020 04:13:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=VTW9Z6nATiVptXlBJyBdVT3cUrJAxe10jV7AlRQnnRI=; b=ZADbOy3Zf1lcfYzr11OnLyQmw6SuSaASuvyjQpxSHu3El/NyAyd7T65x3UlTxBicERkg IaKHK480QL43xet1M7IF/AfZpXW4bQNGeLYPhXr8kb3H0rfQ/VEsRZkZBARCpwewy3D2 1OEaTP9oDHjJKYZlxj954TrCniLuJCBl6N6xpPOemgnCc5dcP4dEJFUqGfXTIQrXdonb UmP6TS1Gm13B/5M3B65KsovdL4Pp2PASWkvnawgqQlHaayer2u4S3tK83o+ix7hKaqNE hsWgfK4DSefmOPF2qVWc1efH5w/Fj0u4ADeY/bbYupELnn3YN7DHT+9lQ0Zgipi8lcTC pg== Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0a-001ae601.pphosted.com with ESMTP id 33nfd285dy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 25 Sep 2020 04:13:16 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 25 Sep 2020 10:13:14 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 25 Sep 2020 10:13:14 +0100 Received: from [10.0.2.15] (ausnpc0lsnw1.ad.cirrus.com [198.61.64.158]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id D10ED2A1; Fri, 25 Sep 2020 09:13:13 +0000 (UTC) Subject: Re: [RFC PATCH 1/2] ASoC: cs47l15: Fix EPOUT->HPOUT1 Mono Mux routing To: CC: , , References: <20200925083410.3987-1-rf@opensource.cirrus.com> From: Richard Fitzgerald Message-ID: <70e57c4e-c4ec-e2f4-aeda-3b6b0afdd417@opensource.cirrus.com> Date: Fri, 25 Sep 2020 10:13:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200925083410.3987-1-rf@opensource.cirrus.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=1 mlxlogscore=999 adultscore=0 clxscore=1015 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009250064 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry. Left a stray "RFC" on the email title. I'm going to kick myself and then re-send. On 25/09/2020 09:34, Richard Fitzgerald wrote: > EPOUT is always mono so should have a permanent routing through the > HPOUT1 Mono Mux. > > Signed-off-by: Richard Fitzgerald > --- > sound/soc/codecs/cs47l15.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/cs47l15.c b/sound/soc/codecs/cs47l15.c > index a591e7457d11..254f9d96e766 100644 > --- a/sound/soc/codecs/cs47l15.c > +++ b/sound/soc/codecs/cs47l15.c > @@ -1089,6 +1089,7 @@ static const struct snd_soc_dapm_route cs47l15_dapm_routes[] = { > { "HPOUT1 Demux", NULL, "OUT1R" }, > > { "OUT1R", NULL, "HPOUT1 Mono Mux" }, > + { "HPOUT1 Mono Mux", "EPOUT", "OUT1L" }, > > { "HPOUTL", "HPOUT", "HPOUT1 Demux" }, > { "HPOUTR", "HPOUT", "HPOUT1 Demux" }, > @@ -1268,7 +1269,6 @@ static irqreturn_t cs47l15_adsp2_irq(int irq, void *data) > > static const struct snd_soc_dapm_route cs47l15_mono_routes[] = { > { "HPOUT1 Mono Mux", "HPOUT", "OUT1L" }, > - { "HPOUT1 Mono Mux", "EPOUT", "OUT1L" }, > }; > > static int cs47l15_component_probe(struct snd_soc_component *component)