Re: [PATCH 43 of 66] don't leave orhpaned swap cache after ksm merging

Andrea Arcangeli
2010-11-09T21:42:16Z

On Tue, Nov 09, 2010 at 12:08:25PM +0900, KOSAKI Motohiro wrote:
> > From: Andrea Arcangeli <aarcange@redhat.com>
> >
> > When swapcache is replaced by a ksm page don't leave orhpaned swap cache.
> >
> > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> > Reviewed-by: Rik van Riel <riel@redhat.com>
>
> This explanation seems to tell this is bugfix. If so, please separate
> this one from THP and will send mainline and -stable soon.

Right. I'm uncertain if this is so bad to require -stable I think, if
it was more urgent I would have submitted already separately but it's
true it's not THP specific.

It's only fatal for cloud computing, where the manager has to decide
to migrate more VM to one node, but it won't if it sees tons of swap
used and it will think there's not enough margin for KSM cows until
the VM is migrated back to another node.