From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757528AbbBENP4 (ORCPT ); Thu, 5 Feb 2015 08:15:56 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:10125 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757511AbbBENPy (ORCPT ); Thu, 5 Feb 2015 08:15:54 -0500 X-AuditID: cbfee61a-f79c06d000004e71-6a-54d36d08dc29 From: Bartlomiej Zolnierkiewicz To: Nick Krause Cc: Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" , One Thousand Gnomes Subject: Re: [PATCH] ata:Remove no longer valid FIXME comment in pata_ninja32.c for the function,ninja32_init_one Date: Thu, 05 Feb 2015 14:15:42 +0100 Message-id: <711574455.M170TblBab@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: References: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> <3201438.osoPqSWP4R@amdc1032> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jQV2O3MshBt0vFS0mTfnLZnFsxyMm i8u75rBZ/Fp+lNHi1xRZB1aPnbPusntsWtXJ5tF6chOrx+dNcgEsUVw2Kak5mWWpRfp2CVwZ cy98YC54L1Ix5c51lgbGMwJdjJwcEgImEicetbNC2GISF+6tZ+ti5OIQEpjOKLHxyFcWCKeF SaLvdCcTSBWbgJXExPZVjCC2iICqxNOvy8CKmAXWMkr0dJwAaufgEBYollh/JxrEZAGqaWnP AinnFdCWWPnzEjOILSrgKbFz+gGwMZwCwRIfpt9jhdi1ilHi46YrzBANghI/Jt9jAbGZBeQl 9u2fygphq0tMmreIeQKjwCwkZbOQlM1CUraAkXkVo2hqQXJBcVJ6rqFecWJucWleul5yfu4m RnAYP5PawbiyweIQowAHoxIPr+W+SyFCrIllxZW5hxglOJiVRHi1si+HCPGmJFZWpRblxxeV 5qQWH2KU5mBREudVsm8LERJITyxJzU5NLUgtgskycXBKNTBOtePMvX+4Pmivk3OpxdlJAYxt kSvXHzw9XztK2NxN/LTqch/DwoYbqW8vM6hOn/Z0zoL9X4T6wzznmggu/M/WrDGZo6NH/+gq 4xT7+UVLVb4/E9HeGC53tyqKr/n91P23X50UW/zglt/i0jihB3mHFuqyaW4/X9Xu5hC/7s77 x23bH33/ci9ciaU4I9FQi7moOBEAPQuWM18CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, February 05, 2015 08:00:24 AM Nick Krause wrote: > On Thu, Feb 5, 2015 at 6:02 AM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Wednesday, February 04, 2015 06:47:41 PM Nicholas Krause wrote: > >> Removes the no longer valid fix me comment in the function, ninja32_init_one for > >> questioning if we are required to remove the activated device at the end of this > >> function by calling the function, ata_host_activate to activate the device passed > >> by the caller of the function ninja_init_one. This comment is no longer needed as > >> we need to deallocate the memory used to store this device's information when the > >> device is no longer in use by the system in order to avoid leaking memory. Due to > >> this the driver in the file,ninja32_init_one has the function,ata_pci_remove_one > >> to release the memory allocated in it's init function and therefore this comment > >> can now be removed due to use correctly freeing the memory allocated from the > >> driver's init function,ninja32_init_one. > >> > >> Signed-off-by: Nicholas Krause > >> --- > >> drivers/ata/pata_ninja32.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c > >> index efb272d..47b30d3 100644 > >> --- a/drivers/ata/pata_ninja32.c > >> +++ b/drivers/ata/pata_ninja32.c > >> @@ -147,7 +147,6 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id) > >> ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE; > >> > >> ninja32_program(base); > >> - /* FIXME: Should we disable them at remove ? */ > > > > After looking at the driver history I think that the comment is about > > ninja32_program() enabling interrupt lines (which don't get disabled when > > the host controller is detached from the driver) not about the cleanup > > done during ata_pci_remove_one(). Alan, is this correct? > > > >> return ata_host_activate(host, dev->irq, ata_bmdma_interrupt, > >> IRQF_SHARED, &ninja32_sht); > >> } > > > > Best regards, > > -- > > Bartlomiej Zolnierkiewicz > > Samsung R&D Institute Poland > > Samsung Electronics > > > If that is the case then I will disable the interrupt lines for the > host in this driver's > remove function. Unless you have hardware to test such change (to check that there are no side-effects) just moving FIXME to ninja32_program() seems to be a better approach for now.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics