* [PATCH] selftest/rseq: Remove duplicate header
@ 2019-03-04 18:38 Souptick Joarder
2019-03-04 18:36 ` Mathieu Desnoyers
2019-03-04 18:49 ` Peter Zijlstra
0 siblings, 2 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-03-04 18:38 UTC (permalink / raw)
To: mathieu.desnoyers, peterz, paulmck, boqun.feng, shuah
Cc: linux-kernel, linux-kselftest
Remove duplicate header which is included twice
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
tools/testing/selftests/rseq/rseq.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/rseq/rseq.h b/tools/testing/selftests/rseq/rseq.h
index c72eb70..6c1126e7 100644
--- a/tools/testing/selftests/rseq/rseq.h
+++ b/tools/testing/selftests/rseq/rseq.h
@@ -16,7 +16,6 @@
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
-#include <sched.h>
#include <linux/rseq.h>
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] selftest/rseq: Remove duplicate header
2019-03-04 18:38 [PATCH] selftest/rseq: Remove duplicate header Souptick Joarder
@ 2019-03-04 18:36 ` Mathieu Desnoyers
2019-03-04 18:49 ` Peter Zijlstra
1 sibling, 0 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2019-03-04 18:36 UTC (permalink / raw)
To: Souptick Joarder, shuah
Cc: Peter Zijlstra, paulmck, Boqun Feng, linux-kernel,
linux-kselftest
----- On Mar 4, 2019, at 1:38 PM, Souptick Joarder jrdr.linux@gmail.com wrote:
> Remove duplicate header which is included twice
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
> tools/testing/selftests/rseq/rseq.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/rseq/rseq.h
> b/tools/testing/selftests/rseq/rseq.h
> index c72eb70..6c1126e7 100644
> --- a/tools/testing/selftests/rseq/rseq.h
> +++ b/tools/testing/selftests/rseq/rseq.h
> @@ -16,7 +16,6 @@
> #include <errno.h>
> #include <stdio.h>
> #include <stdlib.h>
> -#include <sched.h>
> #include <linux/rseq.h>
>
> /*
> --
> 1.9.1
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftest/rseq: Remove duplicate header
2019-03-04 18:38 [PATCH] selftest/rseq: Remove duplicate header Souptick Joarder
2019-03-04 18:36 ` Mathieu Desnoyers
@ 2019-03-04 18:49 ` Peter Zijlstra
2019-03-04 18:53 ` Souptick Joarder
1 sibling, 1 reply; 6+ messages in thread
From: Peter Zijlstra @ 2019-03-04 18:49 UTC (permalink / raw)
To: Souptick Joarder
Cc: mathieu.desnoyers, paulmck, boqun.feng, shuah, linux-kernel,
linux-kselftest
On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> Remove duplicate header which is included twice
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
That SoB chain is invalid.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftest/rseq: Remove duplicate header
2019-03-04 18:49 ` Peter Zijlstra
@ 2019-03-04 18:53 ` Souptick Joarder
2019-03-04 19:57 ` Mathieu Desnoyers
0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2019-03-04 18:53 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Mathieu Desnoyers, Paul McKenney, boqun.feng, shuah, linux-kernel,
linux-kselftest
On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> > Remove duplicate header which is included twice
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> That SoB chain is invalid.
I didn't get why it is invalid ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftest/rseq: Remove duplicate header
2019-03-04 18:53 ` Souptick Joarder
@ 2019-03-04 19:57 ` Mathieu Desnoyers
2019-03-05 6:37 ` Souptick Joarder
0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Desnoyers @ 2019-03-04 19:57 UTC (permalink / raw)
To: Souptick Joarder
Cc: Peter Zijlstra, paulmck, Boqun Feng, shuah, linux-kernel,
linux-kselftest
----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder jrdr.linux@gmail.com wrote:
> On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote:
>>
>> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
>> > Remove duplicate header which is included twice
>> >
>> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>
>> That SoB chain is invalid.
>
> I didn't get why it is invalid ?
I think it's about having the author of the patch (From) as first
Signed-off-by, and then apply following Signed-off-by by maintainers
who pick up the patch. (That's what I am used to see)
What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftest/rseq: Remove duplicate header
2019-03-04 19:57 ` Mathieu Desnoyers
@ 2019-03-05 6:37 ` Souptick Joarder
0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-03-05 6:37 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: Peter Zijlstra, paulmck, Boqun Feng, shuah, linux-kernel,
linux-kselftest
On Tue, Mar 5, 2019 at 1:27 AM Mathieu Desnoyers
<mathieu.desnoyers@efficios.com> wrote:
>
> ----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder jrdr.linux@gmail.com wrote:
>
> > On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >>
> >> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> >> > Remove duplicate header which is included twice
> >> >
> >> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> >> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >>
> >> That SoB chain is invalid.
> >
> > I didn't get why it is invalid ?
>
> I think it's about having the author of the patch (From) as first
> Signed-off-by, and then apply following Signed-off-by by maintainers
> who pick up the patch. (That's what I am used to see)
>
> What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?
Sabyasachi is the author and I am posting his patches as his email client
has some issue. I think I need to add Sabyasachi's From: @ the
beginning of change log.
Andrew suggested the same in another thread.
>
> Thanks,
>
> Mathieu
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-05 6:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 18:38 [PATCH] selftest/rseq: Remove duplicate header Souptick Joarder
2019-03-04 18:36 ` Mathieu Desnoyers
2019-03-04 18:49 ` Peter Zijlstra
2019-03-04 18:53 ` Souptick Joarder
2019-03-04 19:57 ` Mathieu Desnoyers
2019-03-05 6:37 ` Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox