The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>, koraynilay <koray.fra@gmail.com>
Cc: "Pali Rohár" <pali@kernel.org>, "David Sterba" <dsterba@suse.com>,
	"Namjae Jeon" <linkinjeon@kernel.org>,
	"Sungjong Seo" <sj1557.seo@samsung.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <brauner@kernel.org>,
	"Trond Myklebust" <trondmy@kernel.org>,
	"Anna Schumaker" <anna@kernel.org>,
	"Chuck Lever" <cel@kernel.org>,
	"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
	"Paulo Alcantara" <pc@manguebit.org>,
	"Chris Mason" <mason@kernel.org>,
	"Yuezhang Mo" <yuezhang.mo@sony.com>, "Jan Kara" <jack@suse.cz>,
	NeilBrown <neil@brown.name>,
	"Olga Kornievskaia" <okorniev@redhat.com>,
	"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Shyam Prasad N" <sprasad@microsoft.com>,
	"Bharath SM" <bharathsm@microsoft.com>,
	"Sergey Senozhatsky" <senozhatsky@chromium.org>,
	ChenXiaoSong <chenxiaosong@chenxiaosong.com>,
	"Darrick J . Wong" <djwong@kernel.org>,
	"Sean Smith" <defendthedisabled@gmail.com>,
	"Andrey Albershteyn" <aalbersh@kernel.org>,
	"Pedro Falcato" <pfalcato@suse.de>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, exfat@lists.linux.dev,
	ntfs3@lists.linux.dev, linux-cifs@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
	"Theodore Tso" <tytso@mit.edu>
Subject: Re: [RFC PATCH v4 00/10] add provenance time (ptime)
Date: Wed, 18 Nov 2026 09:36:31 -0800	[thread overview]
Message-ID: <7126bdd0ff59e9ea9bc58702af2ecb38096330e8.camel@kernel.org> (raw)
In-Reply-To: <CAOQ4uxiwpdC-fKkqS5kiZ515q9MenC0jX4USV1idN7h2njx45Q@mail.gmail.com>

On Wed, 2026-11-18 at 18:28 +0100, Amir Goldstein wrote:
> On Wed, Nov 18, 2026 at 5:50 PM koraynilay <koray.fra@gmail.com> wrote:
> > 
> > On Wed Nov 18, 2026 at 4:16 PM CET, Pali Rohár wrote:
> > > On Wednesday 18 November 2026 15:58:02 koraynilay wrote:
> > > > On Wed Nov 18, 2026 at 3:26 PM CET, Pali Rohár wrote:
> > > > > Hello,
> > > > > 
> > > > > I have just one issue with the userspace API. It does not allow me to
> > > > > figure out what is the source of statx btime field. If it is fs ptime or
> > > > > fs btime because this RFC implementation is mixing both fs ptime and
> > > > > fs btime into the statx btime field.
> > > > > 
> > > > > I have feeling that this is quite a mess in API and I would like to see
> > > > > a clear distinguish between btime and ptime in the API, like there is a
> > > > > difference in the fs storage.
> > > > > 
> > > > > If the btime is used for forensic analysis then somehow I would expect
> > > > > that the statx would not report / not fill changeable ptime value into
> > > > > the statx btime.
> > > > 
> > > > Hi, for native linux filesystems it will report ptime as PTIME and btime
> > > > as BTIME (also semnatically).
> > > 
> > > That is fine.
> > > 
> > > > for the windows-like ones that only have
> > > > ptime (semantically) I think it's reasonable to not expect btime to be
> > > > immutable, since they are meant to be used with other OSs who lack btime
> > > > semantics.
> > > 
> > > The problem is here that the RFC statx API does not provide this
> > > information that the fs lacks btime semantics and instead it fills
> > > non-immutable ptime value there.
> > > 
> > > I'm pointing only about this inconsistency.
> > > 
> > > > > It would be really helpful if the statx API on inode can differ between:
> > > > > 
> > > > > 1. btime is present and its value is ..., ptime is not supported
> > > > > 2. btime is not supported, ptime is set to value ...
> > > > > 3. btime is present and its value is ..., ptime is set to value ...
> > > > > 4. both btime and ptime are not supported
> > > > > 
> > > > > This should cover all cases of different filesystems and also allows
> > > > > userspace to do proper backup of both ptime and btime fields (if it want
> > > > > to do forensic analysis or anything else).
> > > > 
> > > > These should already all be covered by STATX_BTIME/PTIME and their
> > > > fields in struct statx, the only problems are windows-like filesystems,
> > > > which IMO shuold be handled as mentioned above.
> > > 
> > > Exactly, I pointed out about these problems. I somehow expect that the
> > > new API would be generic and uniform across filesystem. IMHO it does not
> > > matter if the filesystem is windows-like or not (there are also FreeBSD
> > > fs and also others which allows to modify that time). So better
> > > description is fs belongs to category 2. from my above description.
> > 
> > Ah yes, I used windows-like to mean "only have ptime semantics", so same
> > as your category 2.
> > 
> > > > Of course, as in the other discussion, I'm open to changing ptime
> > > > NTFS/exFAT/... support to remove btime altogether and only use ptime for
> > > > their own crtime if that's what wanted (I'm fairly impartial on this
> > > > specific issue).
> > > 
> > > I'm giving some ideas how to possible handle this situation:
> > > 
> > > 1. do not fill btime it at all when it is not available (remove btime
> > >    altogether - the case like you wrote above)
> > 
> > This would be the most semantically correct option, but would break at
> > least 1 script/program/use case.
> > 
> > > 2. when userspace ask both ptime and btime, then do not fill btime
> > >    (remove btime altogether - but only for that new case)
> > 
> > This probably is the best compromise.
> > 
> > > 3. fill btime with ptime value, but add a new output flag indicating that
> > >    the btime is not present at all and instead kernel filled ptime value
> > >    into the statx btime field
> > 
> > I don't really like this, it adds complexity and uses memory/1 flag big
> > for a single specific field, IMO it's not worth it.
> > 
> > > 4. let statx btime as currently is, and add two new statx fields:
> > >    immutable_btime and ptime. immutable_btime would be filled only if the
> > >    fs supports real btime (so not for ntfs/extfat crtime) and ptime would
> > >    be what is currently in RFC
> > 
> > I think this is also too complex.
> > 
> > > Ideas 2. 3. and 4. should be fully backward compatible as it would
> > > affect statx output only when called with new flags.
> > 
> > Then 2. is probably the best way to go forward (maybe I'll include it in
> > some way in v5), but I think we should let each filesystem maintainer
> > decide if they think their users want to have statx report their own
> > crtime as btime, ptime or both (native linux ones would of course
> > report btime as btime and ptime as ptime).
> > 
> 
> Guys,
> 
> Let's take a step back.
> 
> If this discussion is proving anything is that the btime/ptime
> duality is a big headache and it's going to be a source of confusion to users
> even if we come up with some smart pants consistent semantics.
> 
> As Jeff writes, I think we should consider making btime mutable
> be a per-fs choice and not an API limitation.
> 
> A filesystem can even decide to store both the forensics btime
> alongside the user settable crtime.
> 
> There are some precedents in xfs with settable UUID which is
> a different field then the origin UUID from mkfs.
> 
> Fs that have immutable btime have a few choices:
> 1. Keep it immutable
> 2. Start making it muttbale (like the Win fs)
> 3. Start making the user visible btime (STATX_BTIME) mutable
>     but keep the forensics btime on-disk for, well, forensics
> 
> If btime becomes settable via options 2 or 3, this could require
> admin opt-in (e.g. tune2fs -O crtime).
> 
> With option 3 the crtime feature would be ROCOMPAT
> With option 2, it could probably be COMPAT. Maybe.
> 
> If we accept this story and the major fs maintainers are
> in agreement with this plan, then I think the missing piece
> is making the "settable mask" visible to users via the new API.
> 
> IOW, we need to somehow export FS_XFLAG_RDONLY_MASK
> to userspace instead of only exporting the supported mask.
> And then with the addition of xflags_mask, we could also
> -EINVAL on users trying to set readonly flags/values.
> 
> Perhaps a single xflags_settable_mask is enough.
> 
> For file_setattr(), xflags_mask is anyway a set-those mask.
> For file_getattr(), does it matter if we get an answer
> Filesystem does not support casefold on this file
> OR
> Filesystem does not have casefold on this file and
> you cannot set casefold on this file
> 
> It's kind of the same, isn't it?
> 
> What do you say?
> 
> Shall we drop PTIME in favor of "is BTIME settable?" API?
> Leaving STATX_BTIME exactly as is.
> 
> 

+1

I think this is the better approach.

Looking over some of the earlier discussions around this since 2010
(!?!): I think some of the XFS devs objected to making it settable for
forensic reasons. So, on XFS you might need to rev the on-disk format
if you want to do it there to preserve the "historical" btime, and
maybe some xfs userland work to make it accessible for forensics.

For the record, the statx manpage documents the btime field very
sparsely:

       stx_btime
              The file's creation timestamp.

There is no documented guarantee that this will be immutable, AFAICT.
-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2026-11-18 17:36 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 18:03 [RFC PATCH v4 00/10] add provenance time (ptime) koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 01/10] vfs: " koraynilay
2026-11-16 20:10   ` Amir Goldstein
2026-11-16 20:53     ` koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 02/10] vfs: add fileattr_has_fsx_mask() koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 03/10] ntfs3: make crtime user-settable using ptime koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 04/10] exfat: " koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 05/10] btrfs: add provenance time (ptime) koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 06/10] vfs: add __vfs_fileattr_set_locked() for inode_lock()'d callers koraynilay
2026-11-16 13:52   ` Amir Goldstein
2026-11-16 15:55     ` koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 07/10] nfsd: add provenance time (ptime) via FATTR4_TIME_CREATE koraynilay
2026-11-17 22:01   ` Chuck Lever
2026-11-18  0:35     ` koraynilay
2026-11-18  7:44     ` Amir Goldstein
2026-11-18 16:09       ` Chuck Lever
2026-11-18 16:36         ` Amir Goldstein
2026-11-18 17:14           ` Chuck Lever
2026-11-18 17:23             ` koraynilay
2026-11-18 17:37             ` Amir Goldstein
2026-11-15 18:03 ` [RFC PATCH v4 08/10] nfs: " koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 09/10] ksmbd: add provenance time (ptime) and map it to CreationTime koraynilay
2026-11-15 18:03 ` [RFC PATCH v4 10/10] cifs: add provenance time (ptime) and map it to SMB's CreationTime koraynilay
2026-11-17 23:53 ` [RFC PATCH v4 00/10] add provenance time (ptime) Jeff Layton
2026-11-18  1:09   ` koraynilay
2026-11-18  8:14     ` Amir Goldstein
2026-11-18  9:34       ` koraynilay
2026-11-18 13:39         ` Amir Goldstein
2026-11-18 13:58           ` koraynilay
2026-11-18 13:45       ` Jeff Layton
2026-11-18 14:03         ` koraynilay
2026-11-18 14:26 ` Pali Rohár
2026-11-18 14:58   ` koraynilay
2026-11-18 15:16     ` Pali Rohár
2026-11-18 16:50       ` koraynilay
2026-11-18 17:22         ` Pali Rohár
2026-11-18 17:28         ` Amir Goldstein
2026-11-18 17:36           ` Jeff Layton [this message]
2026-11-18 17:50             ` Amir Goldstein
2026-11-18 17:37           ` Pali Rohár
2026-11-18 17:42             ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7126bdd0ff59e9ea9bc58702af2ecb38096330e8.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=aalbersh@kernel.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=amir73il@gmail.com \
    --cc=anna@kernel.org \
    --cc=bharathsm@microsoft.com \
    --cc=brauner@kernel.org \
    --cc=cel@kernel.org \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=defendthedisabled@gmail.com \
    --cc=djwong@kernel.org \
    --cc=dsterba@suse.com \
    --cc=exfat@lists.linux.dev \
    --cc=jack@suse.cz \
    --cc=koray.fra@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=neil@brown.name \
    --cc=ntfs3@lists.linux.dev \
    --cc=okorniev@redhat.com \
    --cc=pali@kernel.org \
    --cc=pc@manguebit.org \
    --cc=pfalcato@suse.de \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sj1557.seo@samsung.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox