* [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c
@ 2009-04-28 22:30 Oleg Nesterov
2009-04-28 22:36 ` Oleg Nesterov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleg Nesterov @ 2009-04-28 22:30 UTC (permalink / raw)
To: Andrew Morton; +Cc: David Howells, Roland McGrath, linux-kernel
->real_parent is the parent. ->parent may be the tracer.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- PTRACE/fs/binfmt_elf_fdpic.c~FDPIC 2009-04-06 00:03:40.000000000 +0200
+++ PTRACE/fs/binfmt_elf_fdpic.c 2009-04-28 21:40:49.000000000 +0200
@@ -1388,7 +1388,7 @@ static void fill_prstatus(struct elf_prs
prstatus->pr_sigpend = p->pending.signal.sig[0];
prstatus->pr_sighold = p->blocked.sig[0];
prstatus->pr_pid = task_pid_vnr(p);
- prstatus->pr_ppid = task_pid_vnr(p->parent);
+ prstatus->pr_ppid = task_pid_vnr(p->real_parent);
prstatus->pr_pgrp = task_pgrp_vnr(p);
prstatus->pr_sid = task_session_vnr(p);
if (thread_group_leader(p)) {
@@ -1433,7 +1433,7 @@ static int fill_psinfo(struct elf_prpsin
psinfo->pr_psargs[len] = 0;
psinfo->pr_pid = task_pid_vnr(p);
- psinfo->pr_ppid = task_pid_vnr(p->parent);
+ psinfo->pr_ppid = task_pid_vnr(p->real_parent);
psinfo->pr_pgrp = task_pgrp_vnr(p);
psinfo->pr_sid = task_session_vnr(p);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c
2009-04-28 22:30 [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c Oleg Nesterov
@ 2009-04-28 22:36 ` Oleg Nesterov
2009-04-29 9:46 ` David Howells
2009-04-29 18:12 ` Roland McGrath
2 siblings, 0 replies; 4+ messages in thread
From: Oleg Nesterov @ 2009-04-28 22:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: David Howells, Roland McGrath, linux-kernel
On 04/29, Oleg Nesterov wrote:
>
> - prstatus->pr_ppid = task_pid_vnr(p->parent);
> + prstatus->pr_ppid = task_pid_vnr(p->real_parent);
> prstatus->pr_pgrp = task_pgrp_vnr(p);
Hmm. Just noticed. What protects ->parent or ->real_parent ?
Looks like we need rcu_lock() around... The same in fs/binfmt_elf.c.
Will send another trivial patch (on top of this) tomorrow.
Oleg.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c
2009-04-28 22:30 [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c Oleg Nesterov
2009-04-28 22:36 ` Oleg Nesterov
@ 2009-04-29 9:46 ` David Howells
2009-04-29 18:12 ` Roland McGrath
2 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2009-04-29 9:46 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: dhowells, Andrew Morton, Roland McGrath, linux-kernel
Oleg Nesterov <oleg@redhat.com> wrote:
> ->real_parent is the parent. ->parent may be the tracer.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c
2009-04-28 22:30 [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c Oleg Nesterov
2009-04-28 22:36 ` Oleg Nesterov
2009-04-29 9:46 ` David Howells
@ 2009-04-29 18:12 ` Roland McGrath
2 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2009-04-29 18:12 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, David Howells, linux-kernel
Acked-by: Roland McGrath <roland@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-29 18:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-28 22:30 [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c Oleg Nesterov
2009-04-28 22:36 ` Oleg Nesterov
2009-04-29 9:46 ` David Howells
2009-04-29 18:12 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox