From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8A1342C9E; Thu, 13 Nov 2025 17:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763053266; cv=none; b=nfARYRQ4NVjro2u6HbiKe0v0lkv/dwtOymoOrX/rj65DbZ3+fC1g1PHVSbLm56iK4B0ijZHJ5EyxEZF6/9QZ01rSIdXI5SVCZWerXNWdcsKgBgfVEgD3eJhgM3JH7vA+eD4hzvNJ8xnVW545ib14E/fkJa5AjWXmmY/A2+5r518= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763053266; c=relaxed/simple; bh=ye4IyFfSxZ58g8jm53tBn5pVbrzvkxaCoznygD5nwos=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Dy0pzcnMo+htVGVkaqJw47T9WGNM/xYBLJQ7RPx3RfJSaSRx+4RFJ1e2BtmxA0Q83jLTH3CuDRXBSxNbKJrTHqe8n5Tk8kffwW6MVdxspCuREqE0WSL26YySskC8BoD97DbKpLn0+aNaoxif4kVvYE8EDlKXWr8MHoeAmWk027U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VWfAyCHo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VWfAyCHo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92A87C4CEF5; Thu, 13 Nov 2025 17:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763053265; bh=ye4IyFfSxZ58g8jm53tBn5pVbrzvkxaCoznygD5nwos=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=VWfAyCHor9vE3FVUHPQtSJJ8LfgHYtOeLyZm25JJIwMMM7Uuc0nmeBgAryufaZgfT 6PybPF7qBdKSkHeHQlMVf8ag3r13yJzYrTVVUb8sTIrWGyFPQ0cwmnbCk+nvyQZ/lf F1qLg+awhv1hckgC0lNM7HJucz9VnjhVaCMAK82oxFgGfNu639eBOnGPlzg5VENNAJ iDlsIVTNB+aa0aNEt6vAqte8NXblSUo8atpC0aFxuXK7pY3n7I1eMZTHjqKLx3moUf cUjng7+/uYXseQTncVVSI5htx6CkJXVszgYc3jdxJBE4WJhtAnAkUwrtpdXFqYYyWS FkF1RIFOTk6qg== Message-ID: <715b0dfd-cd75-401a-acac-0e4ea373dc7d@kernel.org> Date: Thu, 13 Nov 2025 18:01:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mfd: qcom,tcsr: Add compatible for Kaanapali From: Krzysztof Kozlowski To: "Aiqun(Maria) Yu" , Bjorn Andersson Cc: Konrad Dybcio , Jingyi Wang , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-mfd-v1-1-6c8a98760e95@oss.qualcomm.com> <01de9616-825b-4fbb-83cf-e0bf91e8cf39@oss.qualcomm.com> <81174278-c3c4-4dc6-856e-b58aa2cb6fea@oss.qualcomm.com> <4a6f7c18-82d1-499c-af9c-9681e16a0db6@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <4a6f7c18-82d1-499c-af9c-9681e16a0db6@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/11/2025 17:59, Krzysztof Kozlowski wrote: >>> This is what we have for Hamoa: >>> >>> tcsr_mutex: hwlock@1f40000 { >>> compatible = "qcom,tcsr-mutex"; >>> reg = <0 0x01f40000 0 0x20000>; >>> #hwlock-cells = <1>; >>> }; >>> >>> tcsr: clock-controller@1fc0000 { >> >> >> It is not a clock-controller start from 0x1fc0000. >> >>> compatible = "qcom,x1e80100-tcsr", "syscon"; >>> reg = <0 0x01fc0000 0 0x30000>; >> >> This is what we have a discussion initialized here: >> "qcom,-tcsr" is only a tcsr clock controller binder, reference >> from [1]. >> "qcom,tcsr-" is a common tcsr block. reference current binding >> patch. I forgot to trim the quote and paste here one more thing - you completely miss the history, so quoting: "The TCSR block is purely configuration block and should not have children. Any child device should be simply moved outside of TCSR syscon block." This is about this binding. If you claim to make it something else, you are basically changing the meaning of the binding now. >> >> For below hardware block information, is it really a recommendation to >> combine the tscr block with tcsr clock controller all together? >> ______________________ >> | | | >> | TCSR_MUTEX | mutex | >> |_____________|_______| >> | | | >> | RANDOM_REGS | | >> |_____________| | >> | | | >> | TCSR_CLKS | tcsr | >> |_____________| | >> | | | >> | RANDOM_REGS | | >> |_____________|_______| >> >> [1]https://lore.kernel.org/all/20251030-gcc_kaanapali-v2-v2-2-a774a587af6f@oss.qualcomm.com/ >> >> >>> clocks = <&rpmhcc RPMH_CXO_CLK>; >>> #clock-cells = <1>; >>> #reset-cells = <1>; >>> }; >>> >>> This is exactly what I suggested above and Konrad is asking you why >>> this doesn't work for Kaanapali. The addresses are even the same, what >>> is the problem? >> >> The problem is the current patchset document a separate tcsr block as a >> mfd. While the suggestion here is to use the tcsr clock controller > > There is no MFD. Don't use that term in context of supporting a change. > But regardless, this documents only random regs. > >> binding to document the whole tcsr block which is not belonged to tcsr >> clock controller. > > I don't understand whether you claim this patch as "this suggestion" or > something else. > > > Best regards, > Krzysztof Best regards, Krzysztof