From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752097AbbJGMiC (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Oct 2015 08:38:02 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:58426 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750967AbbJGMh7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Oct 2015 08:37:59 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: ygardi@codeaurora.org
Cc: james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org,
        subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org,
        Noa Rubens <noag@codeaurora.org>,
        Raviv Shvili <rshvili@codeaurora.org>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jbottomley@odin.com>,
        "open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: add ioctl interface for query request
Date: Wed, 07 Oct 2015 14:37:35 +0200
Message-ID: <7161690.NZs9VETTEZ@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <c154d3ff11646f056401afd4fa348d1b.squirrel@www.codeaurora.org>
References: <1444204457-14935-1-git-send-email-ygardi@codeaurora.org> <14797522.dgtjTj5niW@wuerfel> <c154d3ff11646f056401afd4fa348d1b.squirrel@www.codeaurora.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:Zw7ECchYeHMLtzjJ9pbMIhVkVl185VI5JLmXMlorNlxlyFaMXf3
 JQP6qfaQCTQnzaW6CNXciVOoYONRlqKjquxc3rznUr/wMgZk9jb9SZtvHa+fWrHie1KOXqj
 TQYKwdG+LIMLNNTXfOPtebKdwomRSzQrFYSNlfSOz/0SGh2pHTjeiv8D/DkFyihCXQwCgdD
 XRXkQF8lyLOU1/sMicgiQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Ql+Qjk7H8Gc=:h5mjKL3y/qySywZsweRRwO
 tTGbfJ1eEGdPGue56WgdgX9FowLuGhZAWZAD5J93FKmA0EHPiByIv8JkZL6PWBIFWlf1K4gTk
 im2jtHtUQgC7dZJgfFKC4lOB1rsQKGaFBdLhv0MADtRLRbfPetZqOn1rXIH8morcGD+VJAaE9
 QNziUW4mcFzxxiORDAf0NA2EaSvHscGePB1v5AtdkfHRDvUGWYWImYXldooHnBzbHuD88K8LK
 edjxV4n5ekpX+tlVVk+FK/qougkv2r7JWgIcdlE7flhl7rqcjnnZfn2AV8UUpsDaVZyHtvmHU
 +gWXC7f2GmR9Bh106AurMpETC4JL2XVnTC9hDKAH3MjS50FssCUKbkhyuTSmuI05RY69YjXKj
 90fRglFBG06oybPNXzrSLt63UelwSiwP9w/+8HkxQr2TeX+oCHhWcrn7Q7GRK7uDHnWeAYM2Q
 EzBZ1dN79x31K4/prS08nRhpgcurCeACmSgoEsEHVgmkxh99Ne5hvtWzZc6NGHPWTsT0f+MVy
 qjgheYeZp9B8iaQXU+9qlklooRp7y8/Vf3A0zqtfc0/paIrESMKs83cqyLZSB6pFauj3oSeab
 XHS4TKHfoufYjY4OA0kGgKTgofRijwRganBqUhKB+secQFnUHy7L5dWnChJU2jtyS1iSRpYBr
 zON2wCobkwDchOHzzqN5FQ3JwcVFGxk7no0hyqmRaqrJQ+8QK56W1U9NtShAA1wtbQuzRH1lJ
 8jFsZs+XNkppa93p
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 07 October 2015 12:27:54 ygardi@codeaurora.org wrote:
> 
> >> +
> >> +/*
> >> + *  IOCTL opcode for ufs queries has the following opcode after
> >> + *  SCSI_IOCTL_GET_PCI
> >> + */
> >> +#define UFS_IOCTL_QUERY                     0x5388
> >
> > Use _IOWR() to define that number with the correct argument length
> 
> i'd rather leave it as is, to be compatible with the SCSI_IOCTL
> opcodes that are defined in scsi_ioctl.h

Do you mean you require this code to work on SunOS? ;-)

If not, better use the normal conventions that Linux and BSD have for
new ioctls.

Note that the 0x53xx ioctl command numbers are also used by
include/uapi/linux/cdrom.h, this one would be right in the middle
of that.

	Arnd