From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932550AbbJPTij (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 15:38:39 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:57015 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753789AbbJPTih (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 15:38:37 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Jiri Slaby <jslaby@suse.cz>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Jonathan Corbet <corbet@lwn.net>,
        Sergei Zviagintsev <sergei@s15v.net>,
        Peter Hurley <peter@hurleysoftware.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Sebastian Reichel <sre@kernel.org>, NeilBrown <neil@brown.name>,
        Grant Likely <grant.likely@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-serial@vger.kernel.org,
        Marek Belisko <marek@goldelico.com>, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver
Date: Fri, 16 Oct 2015 21:38:16 +0200
Message-ID: <7172120.hIQmygRF8G@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <35C9DA36-55B3-44BC-8553-FCBEA2799B7D@goldelico.com>
References: <cover.1445018912.git.hns@goldelico.com> <3951119.loGSTxYIZb@wuerfel> <35C9DA36-55B3-44BC-8553-FCBEA2799B7D@goldelico.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:6Qpyl8ZmsPoBxEG5csW1TwuRegIDmGeWPHeqzA9EnVXcDwVi+ZQ
 UGrONgc0QEnzrOLdR9++ggVwcdEbyh0R6T/FXAhXlVBrHN2xcIYriLmo037/rUdSWdJEJQM
 L7ks914FwR9z92KJ2VOoIhVmeIxcBRMldiZI07vEhWvh9joz40kK+ixZ7gOGmZXE2zoAqnx
 +zPBvEP/XY5ek77reXcQw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wvn9oSPdi+g=:8UQx8WenwdhnoyTBphaDc6
 Lyo24m8/K3ZJfn+m+7PWQxg1B1zxwi++ovFgEVJ60shDTnaz/y/gjtYuGTAfDEj7u2qWp8SKr
 G95wkeI0qlfNleiqdCFqyZdBEn2cECCANzso8aOmluNhlwdvjNDlscMKvpintxQjbf81Gh8xf
 6BKOoO0PjM41nXOHS+TABRWeBD2xVInr91Bf50qD/CDmI0DeVor3N0H88uOeN5Gxds5bRVj9h
 SdTuZEtI8DF4iEHFdM2mfnRHCnWnMFgnxoRvQ+bk6vB5Z/vIqwzCwkvpmY68paYK6d561s5bd
 wEvCH2J68pJOkM2Nb27E3tFqP0PSYBtAD2HqdUuZqTPfOV2xQZO3sfYC666kbTDPjGEpH38VT
 TbEDCvGEVNTsWIZnFnPL1/yhokuTVX+3kl5LsNYWzloYsPbxBgdkFhRT0bUVMJMxIYdWIV1PV
 6Tojls03L5DHvzhbf+AHGSbZSlZC3LBtU1R3qeNJXut51YZTuDkPPo/vDfnLtFOW4MYf/edbm
 ge3q7WxEsjUekqam8CMW0Eeqk2QLDEJLK3Cq1LHiq5XspH0bKIpq4IWF1/AtKF4hO9F5x5XRl
 aJTqkLRuPd/Hml0/ubjnXsNhWLAgn9R7XLNl0P8tO4x/iBVVFeQttmcBnMZWUYCYd+DsqsTa4
 +qjw1f8xj1/AM1yxa0riQOpxYUrBpl3Qk2nln+R560soNZCyBimQjLyO5HFej3mGDyG1VYcju
 SS0FW8oBMEHvi+vr
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 16 October 2015 21:27:11 H. Nikolaus Schaller wrote:
> Am 16.10.2015 um 21:06 schrieb Arnd Bergmann <arnd@arndb.de>:
> 
> > On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
> >> +
> >> +static int w2sg_data_probe(struct platform_device *pdev)
> >> +{
> >> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
> >> +       struct w2sg_data *data;
> >> +       struct rfkill *rf_kill;
> >> +       int err;
> >> +
> >> +       pr_debug("%s()\n", __func__);
> >> +
> >> +       if (pdev->dev.of_node) {
> >> +               struct device *dev = &pdev->dev;
> >> +               enum of_gpio_flags flags;
> >> +
> >> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> >> +               if (!pdata)
> >> 
> > 
> > Why is this a platform_device and not a serio_device?
> 
> I can't find a struct serio_device. What is that?
> 

Sorry, I meant 'struct serio', see drivers/input/serio/

This is an existing infrastructure that is used for devices attached
to a dumb serial device (rs232 or 8042/psaux usually). They have
a user interface for connecting a driver to a port, but you should
be able to do it all in the kernel as well if DT has the information
what device is connected.

	Arnd