The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Xie XiuQi <xiexiuqi@huawei.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: <bp@alien8.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<hpa@zytor.com>, <x86@kernel.org>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: add support SRAO reported via CMC check
Date: Wed, 15 Nov 2017 09:43:07 +0800	[thread overview]
Message-ID: <7180dff1-2e55-5577-85d3-eda288f2be81@huawei.com> (raw)
In-Reply-To: <20171114185139.oo6dr6opk7nup3or@agluck-desk>

Hi Tony,

On 2017/11/15 2:51, Luck, Tony wrote:
> On Tue, Nov 14, 2017 at 01:55:11PM +0800, Xie XiuQi wrote:
>> +	/* known AO MCACODs reported via CMC: */
>> +	MCESEV(
>> +		AO, "Action optional: memory scrubbing error",
>> +		SER, MASK(MCI_UC_SAR|MCACOD_SCRUBMSK, MCI_STATUS_UC|MCACOD_SCRUB)
> 
> I think you should check for OVER=0 (as the existing AO cases do).
> If there was a patrol scrub reported by CMCI, and then another UC
> error, we can't safely treat this as an AO ... because we have no
> idea what the second UC error was.

OK, I'll add check for OVER=0 in v2.

-- 
Thanks,
Xie XiuQi

> 
> -Tony
> 
> .
> 

  reply	other threads:[~2017-11-15  1:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14  5:55 [PATCH] x86/mce: add support SRAO reported via CMC check Xie XiuQi
2017-11-14 18:51 ` Luck, Tony
2017-11-15  1:43   ` Xie XiuQi [this message]
2017-11-15  2:13     ` Luck, Tony
2017-11-15  2:39       ` Xie XiuQi
2017-11-15  2:44         ` Luck, Tony
2017-11-15 10:33           ` Borislav Petkov
2017-11-16  3:00             ` Xie XiuQi
2017-11-16 21:15               ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7180dff1-2e55-5577-85d3-eda288f2be81@huawei.com \
    --to=xiexiuqi@huawei.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox