From: Baolu Lu <baolu.lu@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>, joro@8bytes.org, will@kernel.org
Cc: baolu.lu@linux.intel.com, iommu@lists.linux.dev, jgg@nvidia.com,
linux-kernel@vger.kernel.org, jsnitsel@redhat.com
Subject: Re: [PATCH v6 4/7] iommu: Decouple iommu_domain_alloc() from bus ops
Date: Wed, 22 Nov 2023 09:51:27 +0800 [thread overview]
Message-ID: <719ab0c1-e2a8-4446-8b3f-ba751db0ce27@linux.intel.com> (raw)
In-Reply-To: <6c7313009aae0e39ae2855920990ebf85af4662f.1700589539.git.robin.murphy@arm.com>
On 11/22/23 2:04 AM, Robin Murphy wrote:
> As the final remaining piece of bus-dependent API, iommu_domain_alloc()
> can now take responsibility for the "one iommu_ops per bus" rule for
> itself. It turns out we can't safely make the internal allocation call
> any more group-based or device-based yet - that will have to wait until
> the external callers can pass the right thing - but we can at least get
> as far as deriving "bus ops" based on which driver is actually managing
> devices on the given bus, rather than whichever driver won the race to
> register first.
>
> This will then leave us able to convert the last of the core internals
> over to the IOMMU-instance model, allow multiple drivers to register and
> actually coexist (modulo the above limitation for unmanaged domain users
> in the short term), and start trying to solve the long-standing
> iommu_probe_device() mess.
>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Reviewed-by: Jerry Snitselaar<jsnitsel@redhat.com>
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>
>
> ---
>
> v5: Rewrite, de-scoping to just retrieve ops under the same assumptions
> as the existing code.
> ---
> drivers/iommu/iommu.c | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
next prev parent reply other threads:[~2023-11-22 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 18:03 [PATCH v6 0/7] iommu: Retire bus ops Robin Murphy
2023-11-21 18:03 ` [PATCH v6 1/7] iommu: Factor out some helpers Robin Murphy
2023-11-21 18:03 ` [PATCH v6 2/7] iommu: Decouple iommu_present() from bus ops Robin Murphy
2023-11-21 18:03 ` [PATCH v6 3/7] iommu: Validate that devices match domains Robin Murphy
2023-11-21 18:52 ` Jason Gunthorpe
2023-11-21 18:04 ` [PATCH v6 4/7] iommu: Decouple iommu_domain_alloc() from bus ops Robin Murphy
2023-11-22 1:51 ` Baolu Lu [this message]
2023-11-21 18:04 ` [PATCH v6 5/7] iommu/arm-smmu: Don't register fwnode for legacy binding Robin Murphy
2023-11-21 18:04 ` [PATCH v6 6/7] iommu: Retire bus ops Robin Murphy
2023-11-21 18:04 ` [PATCH v6 7/7] iommu: Clean up open-coded ownership checks Robin Murphy
2023-11-27 10:03 ` [PATCH v6 0/7] iommu: Retire bus ops Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719ab0c1-e2a8-4446-8b3f-ba751db0ce27@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox