From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D5D2C63777 for ; Tue, 17 Nov 2020 20:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2ED4B2225E for ; Tue, 17 Nov 2020 20:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="s9mx6bjL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbgKQUfA (ORCPT ); Tue, 17 Nov 2020 15:35:00 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:10748 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728195AbgKQUe7 (ORCPT ); Tue, 17 Nov 2020 15:34:59 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605645298; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=B5UuYlGm/Tc1iL48YeEinA+NtRG1i1qyUD8YV4GrWcw=; b=s9mx6bjLC1HasZuUZJ+wnLW8k3proxMOpni+YbiI8Wj1Af+Pr2O+PqHG44RmKtJI3kTDaYaZ pUKkGe1RwBaJiC9E9MQWI78ARO77Zma5jHbFSZ/6ZlSSAaihQY3NkhAAsND1P1d244h9PO0T i/iRUbh4AZvzC/8qJXn0nKnSL8k= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fb433f137ede2253bc89c3a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 17 Nov 2020 20:34:57 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A0DE6C43464; Tue, 17 Nov 2020 20:34:57 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id DCB1BC433C6; Tue, 17 Nov 2020 20:34:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Nov 2020 12:34:56 -0800 From: abhinavk@codeaurora.org To: Stephen Boyd Cc: Rob Clark , freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul , kalyan_t@codeaurora.org Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print In-Reply-To: <20201117172608.2091648-1-swboyd@chromium.org> References: <20201117172608.2091648-1-swboyd@chromium.org> Message-ID: <71aebca216babf4010c92d4d1ce9a9b4@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-17 09:26, Stephen Boyd wrote: > I don't know what this debug print is for but it is super chatty, > throwing 8 lines of debug prints in the logs every time we update a > plane. It looks like it has no value. Let's nuke it so we can get > better logs. > > Cc: Sean Paul > Cc: Abhinav Kumar > Signed-off-by: Stephen Boyd > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > index 5e8c3f3e6625..5eb2b2ee09f5 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > @@ -245,9 +245,6 @@ void dpu_vbif_set_qos_remap(struct dpu_kms > *dpu_kms, > forced_on = mdp->ops.setup_clk_force_ctrl(mdp, params->clk_ctrl, > true); > > for (i = 0; i < qos_tbl->npriority_lvl; i++) { > - DPU_DEBUG("vbif:%d xin:%d lvl:%d/%d\n", > - params->vbif_idx, params->xin_id, i, > - qos_tbl->priority_lvl[i]); Instead of getting rid of this print, we should optimize the caller of this. This is what we are doing in downstream. So we need to update the property only if we are switching from a RT client to non-RT client for the plane and vice-versa. So we should try to do the same thing here. is_rt = sde_crtc_is_rt_client(crtc, crtc->state); if (is_rt != psde->is_rt_pipe) { psde->is_rt_pipe = is_rt; pstate->dirty |= SDE_PLANE_DIRTY_QOS; } if (pstate->dirty & DPU_PLANE_DIRTY_QOS) _dpu_plane_set_qos_remap(plane);