Re: [PATCH] eeepc-laptop: enable camera by default

[Corentin Chary <corentin.chary@gmail.com>]

On Fri, Jun 5, 2009 at 10:08 PM, Andrew Morton<akpm@linux-foundation.org> wrote:
> On Fri, 5 Jun 2009 11:59:41 +0300 (EEST)
> Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
>
>>  /*
>> + * Camera helpers
>> + */
>> +
>> +static void eeepc_enable_camera(void)
>> +{
>> +     int err;
>> +
>> +     err = set_acpi(CM_ASL_CAMERA, 1);
>> +     if (err)
>> +             printk(EEEPC_WARNING "Unable to enable camera %d\n", err);
>> +}
>> +
>> +/*
>>   * Sys helpers
>>   */
>>  static int parse_arg(const char *buf, unsigned long count, int *val)
>> @@ -996,6 +1009,9 @@ static int __init eeepc_laptop_init(void)
>
> We can do this:
>
> --- a/drivers/platform/x86/eeepc-laptop.c~eeepc-laptop-enable-camera-by-default-fix
> +++ a/drivers/platform/x86/eeepc-laptop.c
> @@ -334,7 +334,7 @@ static const struct rfkill_ops eeepc_rfk
>  * Camera helpers
>  */
>
> -static void eeepc_enable_camera(void)
> +static void __init eeepc_enable_camera(void)
>  {
>        int err;
>
> _
>
> if we're so inclined?
>

Right, thanks, fixed patch pushed into acpi4asus.

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org