From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBA838E123 for ; Mon, 16 Mar 2026 12:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773665451; cv=none; b=HEFY1fXUUkFST2vQhzdtuJRa+toKQWtq32ryPI+SNG79T3f1Fr16Dqxhkbv/1qd9/kyOh4GGoLZweFJ7EkbzAqVeZZs/GYJ1iJd+p4FrjqMG82dsFshKBC0MzKh0PdhqVSfiEcvMU2SbtBzL9hWZxYwLlfJxMzR/pSWji0zEAZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773665451; c=relaxed/simple; bh=q4TM2LlV744b3L/EatHrhl2+N3BL+B0D8u0nAFHbvnY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tl5Vk5mrtzqPTNlh/znotSr7qGXbBWbcAvbmesMK+WzCVHBr1+TCSeggEReCR+bMyxNuijTFFKP4I0usBwJ8ZG75KFDNiFMvDuhhzBwcqeLpmlxkDZQb7o1CCkVJQcHKDIeOEw5LW6qSdIAPFpbThgX6SW0HX9+rYOhU7mbcx8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dmOHJHkp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YTM2iN05; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dmOHJHkp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YTM2iN05" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GA462F3124560 for ; Mon, 16 Mar 2026 12:50:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EUoaoPLDpNNWBVk0FzY1tCyE6j9Wdf3bW45GK+7R3Sk=; b=dmOHJHkpvjGuOt0p Mn+S4MFRJD728igNpk5vwpHk3sL/CKJFy3HpOvq5wEMuL9tGAyeEQUrYYaFJmL/w Yzf/KzaKS7DagCGnJazuomQhcgKptv9eWmrfWdvBiqTjjV7gZYqQ6SXUU+B4sbO8 XbI7oMDZwQH3ZKdnWVW83c1nmbXg7UaWdXxfHWDryfiSkzs487McV1mXyLm2EFSy LsVm/wXzyuFDiDiqwSkp2qVx93RLtmft5jBSLmkZSFTBGZPEa4s8sPFzGqMK+/Cn cGRgV4uwWkPfWeky3zurdhl2OU79sA/JLql7Jvt4BQH2fToKrj6+MpZ0kdO3TiJw vFgzlg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxfsmgj74-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 12:50:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd8e89d19bso306524585a.2 for ; Mon, 16 Mar 2026 05:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773665447; x=1774270247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EUoaoPLDpNNWBVk0FzY1tCyE6j9Wdf3bW45GK+7R3Sk=; b=YTM2iN05WbgGscYinMZW+QSeiNk8ZTlorMoeZ/ojRyefFbqRRVMZoluev2bsi0OtWZ FYrOIP1u9D/UD56hlUN8bRUkGCsDnuNHFz/Lp/iPlvhA8rGVMlY6mCWQBav2/9FOyNJK ZywWwK4FiW7Ep+TYjG07f57TEG6ynPBgl6iEwGl39PhzXFPPlA9kd/60fbqfSVgGfz/B rHvGf7ABxQ2wquZO+JZQhkKFUtK7FoviwHqMpDw6naEFlurMnw8dykumQhQiAH1anpiM VCgT/RxxEv80eDDQp+z4NGiAt0iFyBaQKM+wrWjh5V8VxNQlYSiguVHaOEnfSw8KR+q6 ZDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773665447; x=1774270247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EUoaoPLDpNNWBVk0FzY1tCyE6j9Wdf3bW45GK+7R3Sk=; b=kMe7SGdqOKmM/5LylZd87a/5c+63c+TxPCdqHRqMSihhQ5D5wMR6X/3x6lBWh53amo Zk5brIAyw1QMa0NJJl7/hCTCXu/aBeqVTuXNkkmyUDLJ+l54K6n9vnvOFLADNPM2zjFY SvfmJpCWrn7N5dABJF7bh8hHuV7hfn7T3cwzPy56n1ZX6VciDYl1dArhC+6GWTHsxy0H fh6DdW0hD7GH8YoZpmtN+rMhcJ9uIEe8s+xYaA96pGQFzYb+pz54gTA2xowPgizdgA0H NrwIHCVsbj4jD4yubl1P3dtUvl9CT7xm+ds6aw8zIuvDCVC2ugrpKGVuNlWtiZJ15yhi 2hAw== X-Forwarded-Encrypted: i=1; AJvYcCVcjXtr64+1c+v6h/6vnyBBCluPEzmZYAHubs8kYCXUMwbWdHy+ZwQD/ngqPEa3gD8/443cJQlckpMoc/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyEANf9sSFhIxoNdmEZ2z/f9PgZ/0e1qZ7rB8RaKBOShFjrzH4J uVpII6JG6NK09oH2NrZ5WwL8LUQ+7voMB9dlyFdiTDRn9ng4myqb3ZeDwXBBXumrIaabrRTjw6i ZjzSssbcEsLT85EWVDK3aAe1y6Z4OVn0lsCPC1p0Zn/VBrbGeOqarBvsHVS5uztEdItQKGTQI/P 0= X-Gm-Gg: ATEYQzw1RbjvZDPIbQYTO9KI+6mv8XFvnQUSyzEaJwzvgGONlWFFNoONfoWE5E8Rokp jF1y4LKlXpoe7nlC4e7LgMy9bL5w3of9PGEv5hHNho0vDQq9Yecu0xWXLa5L4JqMkxPr9YNmZPb Y8+6E7jnXORSar5mgDbdMLgCy9MdcDINliDEdBKmP07zje8YGMRlKwlQ4QhIo4BOBK4qeZ6QKvm RvIPAiTrLQBCVvK+zB131YJd7pV+HD/WbsuXp2wANPVYrKvC4yLk7c/QYkuMDt6UXSy5r5EtZDh VecRsi7XsxQGyXltoMseXVVrYzAJA0EK1xiVlKPRv6RI8ymet2UF5r/5fxKm2eVN8b4AH+JKy7P esKdb/XTZsSYyAEUt0Qbux54tMrlDai8UmnaoC1RHruYs0EanfWeA8t+yRMIU0XmwLfgtrSoQPS Y2GtY= X-Received: by 2002:a05:620a:2948:b0:8cd:8ee7:4473 with SMTP id af79cd13be357-8cdb5a83e13mr1254054685a.4.1773665447276; Mon, 16 Mar 2026 05:50:47 -0700 (PDT) X-Received: by 2002:a05:620a:2948:b0:8cd:8ee7:4473 with SMTP id af79cd13be357-8cdb5a83e13mr1254052885a.4.1773665446900; Mon, 16 Mar 2026 05:50:46 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6650f44a4a2sm1924768a12.15.2026.03.16.05.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 05:50:45 -0700 (PDT) Message-ID: <71f2b29f-a34d-4300-ac9f-ef33694e1f90@oss.qualcomm.com> Date: Mon, 16 Mar 2026 13:50:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Koskovich Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260116-milos-fp6-bt-wifi-v1-0-27b4fbb77e9c@fairphone.com> <20260116-milos-fp6-bt-wifi-v1-4-27b4fbb77e9c@fairphone.com> <52fffc84-2fb5-47aa-835c-b0dd8c110d59@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA5NiBTYWx0ZWRfX9N89E+xAshwE lIr1A+KDhsZhVF8+kYMWq4Y/xKwUGuC5D4ewWAhM2C7TuK3wcSXiJKJbdvZuoDB9ey9mWbcpr4k XYK5LebszeZfcf6ECxYf8MNDkTXaJEWiL5XO+mPq/uVhxsUu3AOcLy3EqZMICV7qMuApibQwacH 6ZWtv7/sx9GmFrTu/Uc8j9dy1IFGcVhN3fDRM0X3Sg9+MdO5Ka4mQHHO4GL5fc/w8N8bv0IOKZ9 moZIjoSm9n6KbsOO3r23gRjEhKGXPzUEd0sKJlNYlRqDZu202KzpNfkuuNPx3wlc+f/YPaRqgnO EOvoJGsXfLmdyogNHI+TeKQA5ioue+LGBJMSMsptLsUpBo4BOEd3nKOjwiV0KUuWQXvJ5eojD8u 8pRYI7/c6D0n4RV20WLA9crPHQjJUdYxZ+RIRUvpsFk9wPkxn8wT/Wev4UTWBD4z2k2cgxcsHOJ qAqrS21WnXuqIcbW4dA== X-Proofpoint-GUID: 8UoG7Cuz7KHVkiovIMA3MY3Xb1frQqqf X-Authority-Analysis: v=2.4 cv=V/hwEOni c=1 sm=1 tr=0 ts=69b7fca8 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=6H0WHjuAAAAA:8 a=UjuIjBpub3zfU3wH7hQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: 8UoG7Cuz7KHVkiovIMA3MY3Xb1frQqqf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160096 On 3/13/26 3:00 PM, Luca Weiss wrote: > On Fri Mar 13, 2026 at 11:40 AM CET, Luca Weiss wrote: >> On Wed Jan 21, 2026 at 12:52 PM CET, Konrad Dybcio wrote: >>> On 1/16/26 3:50 PM, Luca Weiss wrote: >>>> Add the nodes to describe the WCN6755 chip with its PMU and Bluetooth >>>> parts. >>>> >>>> Thanks to Alexander Koskovich for helping with the bringup, adding >>>> 'clocks' to the PMU node to make Bluetooth work. >>>> >>>> Signed-off-by: Luca Weiss >>>> --- >>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 174 +++++++++++++++++++++++ >>>> 1 file changed, 174 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> index 52895dd9e4fa..cbe1507b0aaa 100644 >>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > > > >>>> + bluetooth_enable_default: bluetooth-enable-default-state { >>>> + pins = "gpio53"; >>>> + function = "gpio"; >>>> + output-low; >>>> + bias-disable; >>>> + }; >>> >>> Not sure if we need to drive that pin.. perhaps a pull-down would >>> suffice? >> >> I'll give it a shot, this pinctrl is coming from downstream but perhaps >> the downstream btpower.c driver is differing in behavior to the upstream >> PMU driver. > > Seems to work, but honestly I'm not sure what the actual effects of this > change are? output-low actually actively drives the pin low, while bias-pull-down connects it to an internal pull-down circuit, which is weaker, but also saves power (because the pin isn't actually driven) Konrad