From: Arnd Bergmann <arnd@arndb.de>
To: micky_ching@realsil.com.cn
Cc: chris@printf.net, ulf.hansson@linaro.org, lee.jones@linaro.org,
sameo@linux.intel.com, gregkh@linuxfoundation.org,
dan.carpenter@oracle.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
rogerable@realtek.com, wei_wang@realsil.com.cn
Subject: [PATCH] mmc: rtsx: usb backend needs LED support
Date: Tue, 29 Apr 2014 11:45:59 +0200 [thread overview]
Message-ID: <7208467.nZIXMIfPji@wuerfel> (raw)
In-Reply-To: <cover.1398735435.git.micky_ching@realsil.com.cn>
[hijacking the thread since it has the right Cc list already, sorry]
I stumbled over this doing randconfig builds on linux-next
8<----------
>From c11f54f1e5ea0557e076867ca31c90bcb20e3e0c Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 29 Apr 2014 11:41:40 +0200
Subject: [PATCH] mmc: rtsx: usb backend needs LED support
Building the rtsx USB driver requires the LED classdev base
support, otherwise we get this build error:
drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
:(.text+0x806480): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_probe':
:(.text+0x806708): undefined reference to `led_classdev_register'
This adds an explicit dependency in Kconfig
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 92d91fe..66aedf3 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -696,6 +696,7 @@ config MMC_REALTEK_PCI
config MMC_REALTEK_USB
tristate "Realtek USB SD/MMC Card Interface Driver"
depends on MFD_RTSX_USB
+ depends on LEDS_CLASS
help
Say Y here to include driver code to support SD/MMC card interface
of Realtek RTS5129/39 series card reader
next prev parent reply other threads:[~2014-04-29 9:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 1:54 [PATCH 0/2] mmc: rtsx: revert support for mmc async request micky_ching
2014-04-29 1:54 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch warnings" micky_ching
2014-04-29 7:30 ` Ulf Hansson
2014-05-08 5:49 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove " micky
2014-05-08 7:55 ` Lee Jones
2014-05-08 8:22 ` Ulf Hansson
2014-05-09 1:09 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings" micky
2014-04-29 1:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" micky_ching
2014-04-29 7:36 ` Ulf Hansson
2014-05-05 9:31 ` Ulf Hansson
2014-05-08 7:53 ` Lee Jones
2014-05-08 5:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" micky
2014-04-29 8:02 ` [PATCH 0/2] mmc: rtsx: revert support for mmc async request Lee Jones
2014-04-30 1:32 ` micky
2014-04-29 9:45 ` Arnd Bergmann [this message]
2014-04-29 11:05 ` [PATCH] mmc: rtsx: usb backend needs LED support Ulf Hansson
2014-04-29 12:46 ` Arnd Bergmann
[not found] ` <201404300228.s3U2S7WA026782@rtits1.realtek.com>
2014-04-30 3:34 ` Roger
2014-04-30 7:00 ` Arnd Bergmann
2014-04-30 8:19 ` Ulf Hansson
2014-05-08 8:08 ` Roger
2014-05-08 8:25 ` Arnd Bergmann
2014-05-08 8:29 ` Lee Jones
2014-05-08 8:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7208467.nZIXMIfPji@wuerfel \
--to=arnd@arndb.de \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).