* [2.6 patch] don't offer BINFMT_FLAT on frv
@ 2008-05-21 17:42 Adrian Bunk
2008-05-21 18:56 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-05-21 17:42 UTC (permalink / raw)
To: dhowells; +Cc: linux-kernel, Andrew Morton
This patch fixes the following compile error:
<-- snip -->
...
CC fs/binfmt_flat.o
In file included from
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:36:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/flat.h:14:22: error: asm/flat.h: No such file or directory
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c: In function 'create_flat_tables':
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:124: error: implicit declaration of function 'flat_stack_align'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:125: error: implicit declaration of function 'flat_argvp_envp_on_stack'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c: In function 'calc_reloc':
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:347: error: implicit declaration of function 'flat_reloc_valid'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c: In function 'load_flat_file':
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:479: error: implicit declaration of function 'flat_old_ram_flag'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:755: error: implicit declaration of function 'flat_set_persistent'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:757: error: implicit declaration of function 'flat_get_relocate_addr'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:765: error: implicit declaration of function 'flat_get_addr_from_rp'
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/binfmt_flat.c:781: error: implicit declaration of function 'flat_put_addr_at_rp'
make[2]: *** [fs/binfmt_flat.o] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
e387adf070a8d7522148b3a7ef477340a1162e88 diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
index 55e8ee1..3263084 100644
--- a/fs/Kconfig.binfmt
+++ b/fs/Kconfig.binfmt
@@ -42,7 +42,7 @@ config BINFMT_ELF_FDPIC
config BINFMT_FLAT
bool "Kernel support for flat binaries"
- depends on !MMU
+ depends on !MMU && (!FRV || BROKEN)
help
Support uClinux FLAT format binaries.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] don't offer BINFMT_FLAT on frv
2008-05-21 17:42 [2.6 patch] don't offer BINFMT_FLAT on frv Adrian Bunk
@ 2008-05-21 18:56 ` David Howells
2008-05-28 13:00 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2008-05-21 18:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: dhowells, linux-kernel, Andrew Morton
Looks fine, though I can't test it till next week.
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] don't offer BINFMT_FLAT on frv
2008-05-21 18:56 ` David Howells
@ 2008-05-28 13:00 ` David Howells
0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2008-05-28 13:00 UTC (permalink / raw)
Cc: dhowells, Adrian Bunk, linux-kernel, Andrew Morton
David Howells <dhowells@redhat.com> wrote:
> Looks fine, though I can't test it till next week.
>
> Acked-by: David Howells <dhowells@redhat.com>
Consider it tested too.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-28 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 17:42 [2.6 patch] don't offer BINFMT_FLAT on frv Adrian Bunk
2008-05-21 18:56 ` David Howells
2008-05-28 13:00 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).