From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932465AbWGJLbb (ORCPT ); Mon, 10 Jul 2006 07:31:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932427AbWGJLbb (ORCPT ); Mon, 10 Jul 2006 07:31:31 -0400 Received: from mx1.redhat.com ([66.187.233.31]:51123 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932416AbWGJLba (ORCPT ); Mon, 10 Jul 2006 07:31:30 -0400 From: David Howells In-Reply-To: <20060708111243.28664.74956.sendpatchset@skynet.skynet.ie> References: <20060708111243.28664.74956.sendpatchset@skynet.skynet.ie> <20060708111042.28664.14732.sendpatchset@skynet.skynet.ie> To: Mel Gorman Cc: akpm@osdl.org, davej@codemonkey.org.uk, tony.luck@intel.com, linux-mm@kvack.org, ak@suse.de, bob.picco@hp.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 6/6] Account for memmap and optionally the kernel image as holes X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Mon, 10 Jul 2006 12:30:55 +0100 Message-ID: <7220.1152531055@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Mel Gorman wrote: > +unsigned long __initdata dma_reserve; Should this be static? Or should it be predeclared in a header file somewhere? David