Re: [PATCH v5 4/6] i2c: designware: Implement I2C_M_STOP support

["Benoît Monin" <benoit.monin@bootlin.com>]

On Thursday, 22 January 2026 at 17:25:58 CET, Andy Shevchenko wrote:
> On Tue, Jan 20, 2026 at 10:28:04AM +0100, Benoît Monin wrote:
> > Add the support of the I2C_M_STOP flag in i2c_msg by splitting
> > i2c_dw_xfer() in two: __i2c_dw_xfer_one_part() for the core transfer logic
> > and i2c_dw_xfer() for handling the high-level transaction management.
> > 
> > In detail __i2c_dw_xfer_one_part() starts a transaction and wait for its
> > completion, either with a STOP on the bus or an error. i2c_dw_xfer()
> > loops over the messages to search for the I2C_M_STOP flag and calls
> > __i2c_dw_xfer_one_part() for each part of the messages up to a STOP or
> > the end of the messages array.
> > 
> > i2c_dw_xfer() takes care of runtime PM and holds the hardware lock on
> > the bus while calling __i2c_dw_xfer_one_part(), this allows grouping
> > multiple accesses to device that support a STOP in a transaction when
> > done via i2c_dev I2C_RDWR ioctl.
> 
> Does i2c-tools support this. I.o.w. can you put an example of user space call
> to achieve the above?
> 
I posted a patch series for i2c-tools, adding support for message modifier
flags including I2C_M_STOP to i2ctransfer:
https://lore.kernel.org/all/20251223-msg-flags-v2-0-8d934a4366e2@bootlin.com/

I am working on version 3, following Jean and Wolfram's reviews.

[...]

Thanks for the review!
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com