public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Daniel Pinto <danielpinto52@gmail.com>, <ntfs3@lists.linux.dev>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option
Date: Sat, 12 Nov 2022 21:18:05 +0300	[thread overview]
Message-ID: <7241fb97-c7f7-2136-e93a-b498bcedf5e4@paragon-software.com> (raw)
In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com>



On 10/10/22 14:27, Daniel Pinto wrote:
> Changes v1->v2:
> - Add documentation for hidedotfiles mount option.
> 
> The current implementation of the hidedotfiles has some problems, namely:
> - there is a bug where enabling it actually disables it and vice versa
> - it only works when creating files, not when moving or renaming them
> - it is not listed in the enabled options list by the mount command
> - its name differs from the equivalent hide_dot_files mount option
>    used by NTFS-3G, making it incompatible with it for no reason
> 
> This series of patches tries to fix those problems.
> 
> Daniel Pinto (5):
>    fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
>    fs/ntfs3: make hidedotfiles mount option work when renaming files
>    fs/ntfs3: add hidedotfiles to the list of enabled mount options
>    fs/ntfs3: document the hidedotfiles mount option
>    fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
> 
>   Documentation/filesystems/ntfs3.rst | 6 ++++++
>   fs/ntfs3/frecord.c                  | 9 +++++++++
>   fs/ntfs3/inode.c                    | 2 +-
>   fs/ntfs3/super.c                    | 6 ++++--
>   4 files changed, 20 insertions(+), 3 deletions(-)

Good catch with differences between NTFS-3G and ntfs3.
Applied, thanks!

      parent reply	other threads:[~2022-11-12 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 11:27 [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option Daniel Pinto
2022-10-10 11:30 ` [PATCH v2 1/5] fs/ntfs3: fix hidedotfiles mount option by reversing behaviour Daniel Pinto
2022-10-10 11:32 ` [PATCH v2 2/5] fs/ntfs3: make hidedotfiles mount option work when renaming files Daniel Pinto
2022-10-10 11:34 ` [PATCH v2 3/5] fs/ntfs3: add hidedotfiles to the list of enabled mount options Daniel Pinto
2022-10-10 11:35 ` [PATCH v2 4/5] fs/ntfs3: document the hidedotfiles mount option Daniel Pinto
2022-10-10 11:37 ` [PATCH v2 5/5] fs/ntfs3: rename hidedotfiles mount option to hide_dot_files Daniel Pinto
2022-11-12 18:18 ` Konstantin Komarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7241fb97-c7f7-2136-e93a-b498bcedf5e4@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=danielpinto52@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox