From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751729AbcBKOPn (ORCPT ); Thu, 11 Feb 2016 09:15:43 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:60413 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbcBKOPl (ORCPT ); Thu, 11 Feb 2016 09:15:41 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Lars Persson , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Lars Persson , linux-kernel@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org Subject: Re: [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6 Date: Thu, 11 Feb 2016 15:14:56 +0100 Message-ID: <7242985.WgQduhPVkk@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <0f096d1ad277cf94032ca274ced0cb35cb5d967c.1455198819.git.larper@axis.com> References: <0f096d1ad277cf94032ca274ced0cb35cb5d967c.1455198819.git.larper@axis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Fct6XGv/YaCj5x58UGLTFIEl5lmX+nQJOrqz9feBtZ6fHkrpxCU ABxn2noFEMo/PHHgzgp3cFUbLotTtHUFqJM0J6TNh6bCsNHRO5Kc3N0QeAPlhCht2YDPRQK 2wfa+e/ro3IgMlkEKUhUZvWN7EJXO7YmGeDkO+QngpeEr2eUW4xmjVcE72REWMpfT+FN5Lb UzC0rqKgLsA5QzBLi6zrQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:HE+y5aOYBKw=:KYoEjwZ8y2a0SzpZiNOgF4 lj4QbiBQ1p03W1HRZ160isueFcFJyxysYDPd/WMvBALE9BiqARqvXNHmpAlStAIUUVsXVbNVR 0lOBmqSXuyC03N7XGgurtgUsqbxlHj+2fDx0TtpfnhgdIteUyrWnWvyh20bh281XHDw8cYG3H fANxr7Vw2y+NX49g8fo/5Ek/uFWcFD34tVr6X0VGR+b5ryGiR66Y0CHXYxqYQjDMSWCecyarA RbZX9zoqlMEJ4ADfY5qTnHth2JNwhM3uu3PbYuP7Y4RVpZU9zzWQapA88Ts0VrX3bHUvPbIwC qPBlThl/yp2q4QcRQLizOKQEzKhjfLACG/vpB717Hferag9229X52HvIlCrAH7OFqnUot21BL t2td2/8n+54JLrwtO6sPkKj9BIfMStaCqRt+Ryl6H2jvilTolOzk0c0xkyVtrF5pNRTtkbfqv MRLNj0ThDFjenzcx6SFuXdcyAkCE8Cq2tfO98jMZsDZy4irxsuI51/5J2A965EQuKy8h0vS7t zxscopC78kdsGsddV7ZpanM1dOui1EbOtHJEta7G/Vwg6jDfm8w7EgIkg/Op9DR+jOLvx81aU wNSl4z6qxRh6N570jj1ctbDqBAovZ3uHlKfJ2Z18yBVEL5CY7VhPm6eCENbkHNU5KAgW4llmd vQnX7oZioaSipSBTNFpMXwsoL42gv3wHDtkXg9Vb6nQcvTB06OKyZPnQy1aZuGMj5tcWzvw7j nZBSHzFzz8hlpqXT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 11 February 2016 15:04:37 Lars Persson wrote: > + > +The DMA configuration unit muxes dma request lines between single and burst > +alternatives. > + > +Required properties: > +- compatible: axis,artpec6-dmacfg > +- reg: Address and length of DMACFG register. > + > +Example: > + dmacfg { > + compatible = "axis,artpec6-dmacfg"; > + reg = <0xf8000010 4>; > + }; > + This method looks better than before, but putting a single register into DT looks wrong. I can almost guarantee that there are more registers at 0xf8000000-0xf8000fff (or more) that belong to either some system controller or a DMA controller. Whatever it is, please describe it in the DT in a sensible way based on what the hardware does and what other resources it uses (interrupts etc) rather than what today's kernel happens to need. Arnd