From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from www537.your-server.de (www537.your-server.de [188.40.3.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E7940587A for ; Fri, 5 Jun 2026 07:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.40.3.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645890; cv=none; b=RcX9q9RZooNqBPcggp+eKoqFAqK5j4wTb7cNwG3EXyy9kos/60XBbI5zI1gAO/hGoN1yKIDBH29aypJ4shS2W8GmAPNL2krp8IeZWvMT8c5QINczmqbM059LGCBvryeRTN1JDIvv39/KO0L38zY3HOCPv/8LnbEJVwJIZ9+lFyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645890; c=relaxed/simple; bh=Y8tLcxuKLDFV9lCz+H9hNXgiv8iPCd3GgLo506vk53k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RSCSkFD2i7dW2Bw8Rz5SuzAO7sQuYhsn1fQPCp+P38Y/WhZQEzbfs+FRdFEpnsc9xBZKYy2mns2trLJWrsifFWX8YfFQXl6yAaIKc2W2EhLDAYIJGM65i8wTLDCpIeq39Tm1zSI/34mbi6QikT6FnQ0R9z4F3j7REkPBQ5Ch4Hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=QSmN29ia; arc=none smtp.client-ip=188.40.3.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="QSmN29ia" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ew.tq-group.com; s=default2602; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=h0TITDqHiKdmqJiwNGqI/TMrkaNhKi12bHFtLKztbuQ=; b=QSmN29iayXdZogz7/akqa7Qvi5 6sJBP6ZDiEc6Yiguv0pHSe0UJ7bmerIjwAS0CHk9upxH8qarHjOZXC44Xjm4en8HNXHscZ0GjPrX6 71QS5YYR4JbDDGrxuEd+N2/7KD8ZMe4hmCjpTKN1yxiFPXcNIfpbQc0g85rZ6HohmyWg7uYCQnO82 wQyyz+aIe0YnbmMqhj6FOBTZ2hww12PyzthWu7cTV1Y25IDt/rz3Tl2rw6Z4S/MbCKk87yqua2xb9 7oAy0hQxBFLmj3zn//kjZKoPZW0k75CtjBpUxOt1qxA+HZkoMSVbqjPBNDlWjk+4idHkeW5CNPrF7 J5+2wf9A==; Received: from sslproxy01.your-server.de ([78.46.139.224]) by www537.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1wVPKt-000GWl-0c; Fri, 05 Jun 2026 09:51:23 +0200 Received: from localhost ([127.0.0.1]) by sslproxy01.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wVPKs-000DLF-29; Fri, 05 Jun 2026 09:51:22 +0200 From: Alexander Stein To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , Guangshuo Li Subject: Re: [PATCH] drm/bridge: samsung-dsim: fix TE GPIO ownership Date: Fri, 05 Jun 2026 09:51:21 +0200 Message-ID: <7255371.MhkbZ0Pkbq@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20260604114604.1422184-1-lgs201920130244@gmail.com> References: <20260604114604.1422184-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Virus-Scanned: Clear (ClamAV 1.4.3/28022/Fri Jun 5 08:25:05 2026) Am Donnerstag, 4. Juni 2026, 13:46:04 CEST schrieb Guangshuo Li: > samsung_dsim_register_te_irq() acquires the TE GPIO with > devm_gpiod_get_optional(), but the descriptor is released manually in the > request_threaded_irq() error path and in samsung_dsim_unregister_te_irq(). > The devres entry remains registered and will release the same descriptor > again when the device is detached. >=20 > Use the non-managed gpiod_get_optional() helper instead, so the GPIO > descriptor lifetime matches the existing manual cleanup paths. Also clear > dsi->te_gpio after each gpiod_put() to avoid leaving a stale descriptor > pointer around if the host is attached again. Shouldn't you use devm_gpiod_put instead of gpiod_put? Best regards, Alexander > Fixes: e7447128ca4a ("drm: bridge: Generalize Exynos-DSI driver into a Sa= msung DSIM bridge") > Signed-off-by: Guangshuo Li > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/brid= ge/samsung-dsim.c > index c3eb437ef1b0..2299b7dc0c04 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -1862,7 +1862,7 @@ static int samsung_dsim_register_te_irq(struct sams= ung_dsim *dsi, struct device > int te_gpio_irq; > int ret; > =20 > - dsi->te_gpio =3D devm_gpiod_get_optional(dev, "te", GPIOD_IN); > + dsi->te_gpio =3D gpiod_get_optional(dev, "te", GPIOD_IN); > if (!dsi->te_gpio) > return 0; > else if (IS_ERR(dsi->te_gpio)) > @@ -1875,6 +1875,7 @@ static int samsung_dsim_register_te_irq(struct sams= ung_dsim *dsi, struct device > if (ret) { > dev_err(dsi->dev, "request interrupt failed with %d\n", ret); > gpiod_put(dsi->te_gpio); > + dsi->te_gpio =3D NULL; > return ret; > } > =20 > @@ -1886,6 +1887,7 @@ static void samsung_dsim_unregister_te_irq(struct s= amsung_dsim *dsi) > if (dsi->te_gpio) { > free_irq(gpiod_to_irq(dsi->te_gpio), dsi); > gpiod_put(dsi->te_gpio); > + dsi->te_gpio =3D NULL; > } > } > =20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/